Run CI on PHP 8.3 and 8.4 #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dbu
reviewed
Sep 23, 2024
| @@ -9,6 +9,7 @@ | |||
| ->setRiskyAllowed(true) | |||
| ->setRules([ | |||
| '@Symfony' => true, | |||
| 'trailing_comma_in_multiline' => false, | |||
There was a problem hiding this comment.
i would prefer to fix this rather than diverge from the symfony ruleset.
but as you mentioned in php-http/client-common#247 it would make sense to pin the cs fixer to a specific version to avoid random unrelated cs failures in merge requests.
There was a problem hiding this comment.
We have to do this because the syntax is not compatible with PHP 7.
| @@ -25,6 +25,10 @@ jobs: | |||
| tools: composer:v2 | |||
| coverage: none | |||
|
|
|||
| - name: Emulate PHP 8.3 | |||
| run: composer config platform.php 8.3.999 | |||
There was a problem hiding this comment.
why do we need this? do we have dependencies that limit to php 8.3 and don't install with 8.4?
There was a problem hiding this comment.
phpspec disallows PHP 8.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Run the CI on both PP 8.3 and 8.4.
Why?
Validates compatibility with those PHP versions.
Example Usage
Checklist
To Do