Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix GitHub workflow badge URL #155

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix GitHub workflow badge URL #155

merged 2 commits into from
Oct 23, 2023
+1 −1

Conversation

shoito
Copy link
Contributor

@shoito shoito commented Oct 21, 2023

What's in this PR?

fix GitHub workflow badge URL.

See badges/shields#8671

You need to update your badge URL from
https://img.shields.io/github/workflow/status///Run%20Tests
to
https://img.shields.io/github/actions/workflow/status///test.yml?branch=main

dbu
dbu reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, but we don't use the shields service for the github badge.

the workflow in this repo is indeed called tests.yml and not ci.yml, and we should specify the branch. i will fix that.

dbu
dbu approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, actually the styling can be made consistent if we use shields.io. i like that, actually :D

dbu
dbu reviewed Oct 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@dbu dbu merged commit fb1298f into php-http:1.x Oct 23, 2023
13 of 14 checks passed
@shoito shoito deleted the patch-1 branch October 23, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoito @dbu