Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add testrun for "psr/http-message" v2 #159

Open
wants to merge 3 commits into
base: 1.x
Choose a base branch
from

Conversation

Chris53897
Copy link

see #158

Just for testing the CI

@Chris53897
Copy link
Author

I do not know how to fix the changes between slim 3 and 4.
Did not find an easy migration path.

@dbu
Copy link
Contributor

dbu commented Jan 23, 2024

i am a bit afraid of testing with a dev version.

could we just remove slim from require-dev and add it with composer commands in the github ci for some builds but not all? and have the tests that depend on slim skip if slim is not available?

@Chris53897
Copy link
Author

Yes of course. Maybe they will release a new version?
slimphp/Slim#3311

But i would suggest that the breaking-changes should be fixed first.
At best from someone with more knowledge at this topic.

@dbu
Copy link
Contributor

dbu commented Mar 16, 2024

slim has tagged a release. can you please rebase this branch onto 1.x and push again? then we can see what problems remain.

@Chris53897
Copy link
Author

@dbu Thanks
Now i can work on the support for slim 4.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chris53897 do you have updates on this one? anything blocking, or did you just not find time to continue?

run: |
rm src/MessageFactory/SlimMessageFactory.php src/StreamFactory/SlimStreamFactory.php src/UriFactory/SlimUriFactory.php spec/MessageFactory/SlimMessageFactorySpec.php spec/StreamFactory/SlimStreamFactorySpec.php spec/UriFactory/SlimUriFactorySpec.php
composer remove --dev "slim/slim" --no-interaction --no-update
composer require "psr/http-message:^2.0" --no-interaction --no-update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we not keep this test around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants