Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version #35

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Fix version #35

merged 1 commit into from
Apr 12, 2021

Conversation

remicollet
Copy link
Contributor

No description provided.

@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

@remicollet totally missed that one, thx a lot 🙇

@nick-zh nick-zh merged commit 6052757 into php-kafka:main Apr 12, 2021
@remicollet
Copy link
Contributor Author

The strange thing is that this value is usually tested during package upload on pecl, and reported as broken when it doesn't match the expected value...

BTW, perhaps because of non standard macro name, should be change from PHP_KAFKA_VERSION to PHP_SIMPLE_KAFKA_CLIENT_VERSION

FYI, this extension is now also available as RPM in my repository among others
https://blog.remirepo.net/pages/PECL-extensions-RPM-status
And announced to users
https://twitter.com/RemiRepository/status/1381496793276497921

@nick-zh
Copy link
Member

nick-zh commented Apr 12, 2021

Thank you very much 🙇
I hope the broken version did not mess up anything.
I will keep it in mind to change it as well during every release 😅
I agree, i created a PR to change the macro name #37 , thx again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@remicollet @nick-zh