Add php 7.3 support (#29)

* Add php 7.3 support * Fix tests
php-middleware · May 2, 2019 · 25cec6e · 25cec6e
1 parent daa1985
commit 25cec6e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -7,6 +7,7 @@ language: php
 php:
   - 7.1
   - 7.2
+  - 7.3
 
 env:
   - DEPS=lowest

diff --git a/test/PhpDebugBarMiddlewareTest.php b/test/PhpDebugBarMiddlewareTest.php
@@ -27,6 +27,7 @@ protected function setUp()
     {
         $this->debugbarRenderer = $this->getMockBuilder(JavascriptRenderer::class)->disableOriginalConstructor()->getMock();
         $this->debugbarRenderer->method('renderHead')->willReturn('RenderHead');
+        $this->debugbarRenderer->method('getBaseUrl')->willReturn('/phpdebugbar');
         $this->debugbarRenderer->method('render')->willReturn('RenderBody');
         $responseFactory = new ResponseFactory();
         $streamFactory = new StreamFactory();
@@ -234,8 +235,6 @@ public function testAppendsToEndOfHtmlResponse(): void
 
     public function testTryToHandleNotExistingStaticFile(): void
     {
-        $this->debugbarRenderer->expects($this->any())->method('getBaseUrl')->willReturn('/phpdebugbar');
-
         $uri = new Uri('http://example.com/phpdebugbar/boo.css');
         $request = new ServerRequest([], [], $uri, null, 'php://memory');
         $response = new Response\HtmlResponse('<html></html>');
@@ -254,7 +253,6 @@ public function testHandleStaticFile(string $extension, string $contentType): vo
     {
         $root = vfsStream::setup('boo');
 
-        $this->debugbarRenderer->expects($this->any())->method('getBaseUrl')->willReturn('/phpdebugbar');
         $this->debugbarRenderer->expects($this->any())->method('getBasePath')->willReturn(vfsStream::url('boo'));
 
         $uri = new Uri(sprintf('http://example.com/phpdebugbar/debugbar.%s', $extension));