Autoload static files without copy/paste #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| $staticResponse = new Response(); | ||
| $staticResponse->getBody()->write(file_get_contents($fullPathToFile)); |
There was a problem hiding this comment.
Better: create a new stream instance and pass it to the response on creation. When creating the stream instance, give it the path to the file:
$stream = new Stream($fullPathToFile, 'r');
$staticResponse = new Response($stream);That way you don't have any memory overhead from reading the file, and keep I/O down to a minimum.
|
I like it! Let me know when you've merged and tagged, and I'll update the expressive docs (as I have detailed the copy + baseUrl method currently). |
|
Thanks for advice! I will merge it tomorrow. |
snapshotpl
added a commit
that referenced
this pull request
Jan 9, 2016
Autoload static files without copy/paste
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr make installation simple as possible and make middleware ready to use out-of-box. Solution for #2