Skip to content

Commit

Permalink
GH Actions: fix duplicate release
Browse files Browse the repository at this point in the history
As things were, the workflow was creating two releases, one in draft and one published, but without a good name/changelog.
I noticed this last time there was a release, but never got round to fixing it (and it wasn't urgent as no new release was needed).

As a new release is needed soon, now seemed like a good time to fix this.

The `actions/create-release` action runner has been abandoned and mentions the `softprops/action-gh-release` action runner as a replacement.

This commit now updates the workflow to solely use the `softprops/action-gh-release` action runner and updates the version and configuration to make sure it only creates a draft release, so we can still edit it and add the changelog before publishing.
  • Loading branch information
jrfnl authored and grogy committed Mar 27, 2024
1 parent c18e8ad commit c3b494c
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,12 @@ jobs:
name: parallel-lint-phar

- name: Draft Release
uses: actions/create-release@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
uses: softprops/action-gh-release@v2
with:
tag_name: ${{ github.ref }}
release_name: Release ${{ github.ref }}
draft: true
prerelease: false

- name: Upload Phar as Release Asset
id: upload-release-asset
uses: softprops/action-gh-release@v2
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
make_latest: true
files: parallel-lint.phar
fail_on_unmatched_files: true

0 comments on commit c3b494c

Please sign in to comment.