Skip to content

Commit

Permalink
GH Actions: run tests also on Windows OS
Browse files Browse the repository at this point in the history
When running the tests locally, I realized that patch 146 did not actually work correctly on Windows.

This commit adds test runs against Windows in CI on a limited number of PHP versions to prevent this kind of issue going unnoticed for future PRs.

Note: the lowest PHP version I can get a running build on is PHP 5.5. This is related to SSL transport issues with Packagist with old Composer versions (which are needed for old PHP versions).
  • Loading branch information
jrfnl committed Mar 27, 2024
1 parent 03bd781 commit dffe775
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ jobs:
path: ./parallel-lint.phar

test:
name: Run tests on PHP ${{ matrix.php }}
runs-on: ubuntu-latest
name: Run tests on PHP ${{ matrix.php }} (${{ matrix.os }})
runs-on: "${{ matrix.os }}"
continue-on-error: ${{ matrix.php == '8.4' }}
needs:
- bundle
Expand All @@ -114,6 +114,19 @@ jobs:
- '8.2'
- '8.3'
- '8.4'
os:
- 'ubuntu-latest'

include:
# Also run the tests against Windows on a few PHP versions.
- php: '5.5'
os: 'windows-latest'
- php: '7.0'
os: 'windows-latest'
- php: '8.0'
os: 'windows-latest'
- php: '8.3'
os: 'windows-latest'

steps:
- name: Checkout code
Expand Down

0 comments on commit dffe775

Please sign in to comment.