Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: fix duplicate release #159

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Mar 16, 2024

As things were, the workflow was creating two releases, one in draft and one published, but without a good name/changelog. I noticed this last time there was a release, but never got round to fixing it (and it wasn't urgent as no new release was needed).

As a new release is needed soon, now seemed like a good time to fix this.

The actions/create-release action runner has been abandoned and mentions the softprops/action-gh-release action runner as a replacement.

This commit now updates the workflow to solely use the softprops/action-gh-release action runner and updates the version and configuration to make sure it only creates a draft release, so we can still edit it and add the changelog before publishing.

@jrfnl jrfnl added this to the 1.3.x Next milestone Mar 16, 2024
@jrfnl jrfnl requested a review from grogy March 16, 2024 21:04
@jrfnl jrfnl force-pushed the feature/ghactions-fix-release-being-created-twice branch from c312a8b to 271b8b1 Compare March 27, 2024 10:38
As things were, the workflow was creating two releases, one in draft and one published, but without a good name/changelog.
I noticed this last time there was a release, but never got round to fixing it (and it wasn't urgent as no new release was needed).

As a new release is needed soon, now seemed like a good time to fix this.

The `actions/create-release` action runner has been abandoned and mentions the `softprops/action-gh-release` action runner as a replacement.

This commit now updates the workflow to solely use the `softprops/action-gh-release` action runner and updates the version and configuration to make sure it only creates a draft release, so we can still edit it and add the changelog before publishing.
@jrfnl jrfnl force-pushed the feature/ghactions-fix-release-being-created-twice branch from 271b8b1 to 3e22507 Compare March 27, 2024 11:12
Copy link
Member

@grogy grogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will merge it

@grogy grogy merged commit 03bd781 into develop Mar 27, 2024
17 checks passed
@grogy grogy deleted the feature/ghactions-fix-release-being-created-twice branch March 27, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants