Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: Re-enable jacoco coverage report #62

Closed
SpraxDev opened this issue May 27, 2022 · 3 comments · Fixed by #88
Closed

GitHub Actions: Re-enable jacoco coverage report #62

SpraxDev opened this issue May 27, 2022 · 3 comments · Fixed by #88
Assignees
@SpraxDev
Labels
dependencies Pull requests that update a dependency file dx Developer Experience
Milestone
v1.1.0

Comments

@SpraxDev
Copy link
Contributor

SpraxDev commented May 27, 2022 •
edited
Loading

When updating org.jetbrains.intellij in 8145a86 (#59) the jacoco report generation started failing with the errors

Caused by: : Error while creating report
[...]
Caused by: java.io.IOException: Error while analyzing /home/runner/work/ddev-intellij-plugin/ddev-intellij-plugin/build/classes/java/main/de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl.class.
[...]
Caused by: java.lang.IllegalStateException: Can't add different class with same name: de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl

This doesn't feel like an error on our side, so the commit ea6955a in (#59) should be reverted as soon as an update is available that fixes the issue.

Additionally the SonarCloud workflow should be re-enabled again. It keeps failing with OutOfMemory errors
SpraxDev added a commit that referenced this issue May 27, 2022
@SpraxDev
GitHub Actions: Temporarily removes jacoco report generation (#62)
de6e97a 
The issue (#62) serves as an reminder that this commit should be reverted as soon as this is fixed.

jacoco is currently failing and breaking the test pipeline, hopefully this is not an issue on our side and will be fixed in the next release.


> Caused by: : Error while creating report
> [...]
> Caused by: java.io.IOException: Error while analyzing /home/runner/work/ddev-intellij-plugin/ddev-intellij-plugin/build/classes/java/main/de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl.class.
> [...]
> Caused by: java.lang.IllegalStateException: Can't add different class with same name: de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl
@SpraxDev SpraxDev added dx Developer Experience dependencies Pull requests that update a dependency file labels May 27, 2022
SpraxDev added a commit that referenced this issue May 27, 2022
@SpraxDev
GitHub Actions: Temporarily removes jacoco report generation (#62)
ea6955a 
The issue (#62) serves as an reminder that this commit should be reverted as soon as this is fixed.

jacoco is currently failing and breaking the test pipeline, hopefully this is not an issue on our side and will be fixed in the next release.


> Caused by: : Error while creating report
> [...]
> Caused by: java.io.IOException: Error while analyzing /home/runner/work/ddev-intellij-plugin/ddev-intellij-plugin/build/classes/java/main/de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl.class.
> [...]
> Caused by: java.lang.IllegalStateException: Can't add different class with same name: de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl
@SpraxDev SpraxDev changed the title GitHub Action: Re-enable jacoco coverage report for tests GitHub Action: Re-enable jacoco coverage report for tests and SonarCloud-Workflow May 27, 2022
nico-loeber added a commit that referenced this issue Jun 4, 2022
@dependabot @nico-loeber @SpraxDev
Bump org.jetbrains.intellij from 1.5.3 to 1.6.0 (#59)
d3c830f 
* Bump org.jetbrains.intellij from 1.5.3 to 1.6.0

* GitHub Actions: Run test with `--stacktrace` option

* GitHub Actions: Temporarily removes jacoco report generation (#62)

The issue (#62) serves as an reminder that this commit should be reverted as soon as this is fixed.

jacoco is currently failing and breaking the test pipeline, hopefully this is not an issue on our side and will be fixed in the next release.

> Caused by: : Error while creating report
> [...]
> Caused by: java.io.IOException: Error while analyzing /home/runner/work/ddev-intellij-plugin/ddev-intellij-plugin/build/classes/java/main/de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl.class.
> [...]
> Caused by: java.lang.IllegalStateException: Can't add different class with same name: de/php_perfect/intellij/ddev/statusBar/DdevStatusBarWidgetFactoryImpl

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nico Löber <nico.loeber94@gmail.com>
Co-authored-by: Christian Koop <contact@sprax2013.de>
@nico-loeber
Copy link
Contributor

I guess the issue might be on our side, since it did no exists before merging the dependency updates.
The test report package was not updated. Maybe this might also have something to do with memory limits or other JVM configuration?

@nico-loeber nico-loeber added this to the v1.0.0 milestone Jun 5, 2022
SpraxDev added a commit that referenced this issue Jun 7, 2022
@SpraxDev
Re-enables jacoco coverage report (#62)
f2ea470 
I believe JetBrains changed something about their compile steps causing jacoco to find mutliple versions of compiled classes in different directories.
Explicitly setting the class directory to use fixes the issues we had in #59
@SpraxDev SpraxDev linked a pull request Jun 7, 2022 that will close this issue
Re-enables jacoco coverage report (#62) #69
Closed
@SpraxDev SpraxDev removed a link to a pull request Jun 7, 2022
Re-enables jacoco coverage report (#62) #69
Closed
@nico-loeber nico-loeber mentioned this issue Jun 14, 2022
Closed
@nico-loeber nico-loeber modified the milestones: v1.0.0, v1.1.0 Jul 5, 2022
@nico-loeber
Copy link
Contributor

The code coverage issue should be fixed now by

SpraxDev added a commit that referenced this issue Jul 21, 2022
@SpraxDev
Revert "GitHub Actions: Temporarily removes jacoco report generation (#…
bbfefc8 
…62)"

This reverts commit ea6955a.
@SpraxDev SpraxDev mentioned this issue Jul 21, 2022
Merged
2 tasks
@SpraxDev
Copy link
Contributor Author

Looks like there are still some issues. Could not get it to not detect 0% coverage and found a ticket about that.

I've subscribed to it and maybe they find something that needs to be configured or fixed in the intellij-plugin.

JetBrains/intellij-platform-gradle-plugin#1065

@SpraxDev SpraxDev changed the title GitHub Action: Re-enable jacoco coverage report for tests and SonarCloud-Workflow GitHub Action: Re-enable jacoco coverage report Jul 24, 2022
@SpraxDev SpraxDev changed the title GitHub Action: Re-enable jacoco coverage report GitHub Actions: Re-enable jacoco coverage report Jul 24, 2022
SpraxDev added a commit that referenced this issue Aug 5, 2022
@SpraxDev
Revert "GitHub Actions: Temporarily removes jacoco report generation (#…
4001575 
…62)"

This reverts commit ea6955a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SpraxDev SpraxDev

Labels
dependencies Pull requests that update a dependency file dx Developer Experience
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Re-enable test coverage report php-perfect/ddev-intellij-plugin
2 participants
@SpraxDev @nico-loeber