Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require league/uri 7 #13

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

simoheinonen
Copy link
Contributor

Q A
Type improvement
BC Break yes
Fixed issues

Summary

Drops "league/uri": "^6.5" so this'll need to bump up the major version

@simoheinonen
Copy link
Contributor Author

Symfony is going to release 7.0 soon so should probably allow that in this (and #12) too

@veewee veewee mentioned this pull request Nov 20, 2023
@veewee
Copy link
Member

veewee commented Nov 20, 2023

Nice!

I'm gonna tag this as 1.5 since I don't believe this is a BC break inside this package : the public API of that class (which is kinda something internal anyways) did not change. People on older deps can continue using 1.4 or lower, whilst people who want to upgrade that specific URI package can continue as they do today with the latest version of URI.

@veewee veewee merged commit 4767af9 into php-soap:main Nov 20, 2023
6 checks passed
@simoheinonen
Copy link
Contributor Author

Oops yeah, you're correct. 1.5 is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants