[Regex] Capture groups typehint #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
commented
Apr 9, 2021
veewee
force-pushed
the
regex-matching
branch
2 times, most recently
from
b137ec2 to
2748ae5
Compare
azjezz
reviewed
Apr 9, 2021
azjezz
reviewed
Apr 9, 2021
azjezz
reviewed
Apr 9, 2021
Comment on lines
+51
to
+53
| if (!$type instanceof Type\Atomic\TLiteralInt && !$type instanceof Type\Atomic\TLiteralString) { | ||
| return self::fallbackType(); | ||
| } |
There was a problem hiding this comment.
do you think we should add an invalid argument issue here if the argument values are not literal?
There was a problem hiding this comment.
The argument is typed as list<array-key>
So it is not really a valid case I suppose?
There was a problem hiding this comment.
we can still trigger errors from here, but not sure it's worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better return types for Regex\capture_groups introduced in:
azjezz/psl#151