Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum support #12

Merged
merged 8 commits into from
Jun 8, 2023
Merged

Enum support #12

merged 8 commits into from
Jun 8, 2023

Conversation

hungthai1401
Copy link
Member

Hello @WendellAdriel and @chrisjumptwentyfour ,
This PR implement the enum support.
Please let me know if there are any changes required.
Greetings and thanks,
Thai

Copy link
Member

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungthai1401 that's a nice addition.
It would be nice to add some test cases with Backed Enums as well.

@hungthai1401
Copy link
Member Author

@WendellAdriel Yeah, I will add Backed Enums test cases and fix lint code asap

@hungthai1401
Copy link
Member Author

@WendellAdriel I have added backed enum test cases Plz review them

Copy link
Member

@WendellAdriel WendellAdriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You added the backed enum only to a single test case, you need to add it to the other test cases as well

@hungthai1401
Copy link
Member Author

@WendellAdriel I have add more backed enum test cases

@WendellAdriel
Copy link
Member

@hungthai1401 please check that your branch is updated with main and that you run the composer lint command to fix the code style issues.

@hungthai1401
Copy link
Member Author

@WendellAdriel it already up to date and I have fixed code style issues

@WendellAdriel
Copy link
Member

@hungthai1401 thanks for the contribution!
I'll merge it and we will prepare a new release soon with your changes! 🔥 💪

@WendellAdriel WendellAdriel merged commit 52fa9b5 into php-strictus:main Jun 8, 2023
@hungthai1401
Copy link
Member Author

@WendellAdriel thanks for your great packages

@WendellAdriel
Copy link
Member

@WendellAdriel thanks for your great packages

I'm happy to be able to help other devs!!! 💪

@hungthai1401 hungthai1401 deleted the feature/enum branch June 26, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants