-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum support #12
Enum support #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hungthai1401 that's a nice addition.
It would be nice to add some test cases with Backed Enums as well.
@WendellAdriel Yeah, I will add Backed Enums test cases and fix lint code asap |
@WendellAdriel I have added backed enum test cases Plz review them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You added the backed enum only to a single test case, you need to add it to the other test cases as well
@WendellAdriel I have add more backed enum test cases |
@hungthai1401 please check that your branch is updated with |
@WendellAdriel it already up to date and I have fixed code style issues |
@hungthai1401 thanks for the contribution! |
@WendellAdriel thanks for your great packages |
I'm happy to be able to help other devs!!! 💪 |
Hello @WendellAdriel and @chrisjumptwentyfour ,
This PR implement the enum support.
Please let me know if there are any changes required.
Greetings and thanks,
Thai