New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gd: do not use or unnecessary reference imagedestroy() #4396

Merged

kamil-tekiela merged 1 commit into php:master from pereorga:imagedestroy-deprecated

Jan 16, 2025

Contributor

pereorga commented Jan 14, 2025

Because imagedestroy() is NOP in all supported PHP versions (as of 8.0.0), there is no need to reference it.


          gd: do not use or unnecessary reference imagedestroy()

5ee405f

kamil-tekiela approved these changes

View reviewed changes

Member

kamil-tekiela left a comment

Thanks. I feel sorry for translators but this is a good change that we'd have to make sooner or later.

kamil-tekiela merged commit 9960a09 into php:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet