Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createfromstring.xml Fix typo: document → string + CS #4408

Closed
wants to merge 2 commits into from
Closed

createfromstring.xml Fix typo: document → string + CS #4408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e54613
createfromstring.xml Fix typo: document → string + CS
mmalferov Jan 20, 2025
111f2de
Update createfromstring.xml
mmalferov Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions reference/dom/dom/htmldocument/createfromstring.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<refsect1 role="returnvalues">
&reftitle.returnvalues;
<simpara>
The parsed document as an <classname>Dom\HTMLDocument</classname> instance.
The parsed string as an <classname>Dom\HTMLDocument</classname> instance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually https://www.php.net/manual/en/dom-htmldocument.createfromfile.php uses the same phrasing, and I kinda used "parsed document" on purpose. But I don't object changing this (if done consistently)

</simpara>
</refsect1>

Expand All @@ -64,11 +64,12 @@
<example xml:id="dom-htmldocument.createfromstring.example.basic">
<title><methodname>Dom\HTMLDocument::createFromString</methodname> example</title>
<simpara>
Parses a sample document.
Parses a sample string.
</simpara>
<programlisting role="php">
<![CDATA[
<?php

$dom = Dom\HTMLDocument::createFromString(<<<'HTML'
<!DOCTYPE html>
<html>
Expand All @@ -77,7 +78,9 @@ $dom = Dom\HTMLDocument::createFromString(<<<'HTML'
</body>
</html>
HTML);

echo $dom->saveHtml();

?>
]]>
</programlisting>
Expand Down
Loading