Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to match #86

Merged
merged 1 commit into from
May 13, 2024
Merged

Add examples to match #86

merged 1 commit into from
May 13, 2024

Conversation

Marqitos
Copy link
Contributor

Sync example:
Basic match usage

And add a new example using Comparison Operators

@Marqitos
Copy link
Contributor Author

Validation of operation of the example using Comparison Operators
https://onlinephp.io/c/7045b

Attribution of the example to the programmer: Miguel Ángel Durán
https://github.com/midudev

Showing the example on YouTube:
https://youtu.be/BcGAPkjt_IE?si=K1obFhZs8OI3FzZR&t=3332

@julionc julionc merged commit 2716a20 into php:master May 13, 2024
1 check passed
@Girgias
Copy link
Member

Girgias commented May 13, 2024

New examples should not be added to translations, they should be added to doc-en if useful, and translations should replicate the changes. This file also doesn't have a doc-en revcheck tag, so there is no way to know if this file is up to date or not with the English translation.

@Marqitos
Copy link
Contributor Author

I can add the same example in doc-en.

@Girgias
Copy link
Member

Girgias commented May 20, 2024

I can add the same example in doc-en.

This would be appreciated.

@Marqitos
Copy link
Contributor Author

I have requested to add the code example in doc-en
Add new example to match using comparison operators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants