Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support PHP 8.1 #9

Merged
merged 1 commit into from
May 23, 2022
Merged

Add support PHP 8.1 #9

merged 1 commit into from
May 23, 2022

Conversation

zeriyoshi
Copy link
Contributor

1.0.4 works fine with PHP 8.1 as it is now, but it seems that it cannot be installed from PECL due to a limitation in package.xml.
I would like to see it released as 1.0.5 with no changes to the implementation.

@zeriyoshi
Copy link
Contributor Author

@remicollet
Do you plan to fix this issue?
It is possible to workaround this by installing from source, but that is very tricky 😭

@remicollet
Copy link
Member

@zeriyoshi I'm not the lead of this extension, see https://pecl.php.net/package/mcrypt

BTW, perhaps time to get rid of this dead cow...

@zeriyoshi
Copy link
Contributor Author

zeriyoshi commented May 23, 2022

@remicollet
Oops, sorry!
I will contact the official maintainer. Thanks.

BTW, perhaps time to get rid of this dead cow...

👍🏼
I use this to upgrade PHP with as little modification to the existing system as possible.
This should not be used for new applications.

@zeriyoshi
Copy link
Contributor Author

@derickr
Can you help us?
Working fine with PHP 8.1 at this time. The only problem is the manifest.

But, Remi's says, may want to start thinking about future maintenance.

@remicollet
Copy link
Member

But, Remi's says, may want to start thinking about future maintenance.

I mean this ext is there for legacy needs.
I recommend you read
https://blog.remirepo.net/post/2015/07/07/About-libmcrypt-and-php-mcrypt
which explain why using mcrypt is a bad idea, and why it have been removed from php-src and moved to pecl.

@derickr derickr merged commit d821f9a into php:master May 23, 2022
@zeriyoshi
Copy link
Contributor Author

zeriyoshi commented May 23, 2022

Thank you @remicollet @derickr

I am aware of this and have previously attempted to rework my application using ext-openssl.

However, there were some incompatibilities, which could have been fixed with additional support, but time was short and I decided to use PECL mcrypt. The same is true this time.

I am in favor of abolish this extension altogether in the future.

Copy link

@Madcanna Madcanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kann mir jemand sagen was ich tun soll habe keine Ahnung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants