Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing CURL_HTTP_VERSION_3 constant #11755

Closed
nicolas-grekas opened this issue Jul 21, 2023 · 7 comments
Closed

Missing CURL_HTTP_VERSION_3 constant #11755

nicolas-grekas opened this issue Jul 21, 2023 · 7 comments
Assignees
@adoy
Labels
Extension: curl Feature

Comments

@nicolas-grekas
Copy link
Contributor

nicolas-grekas commented Jul 21, 2023 •
edited
Loading

Description

In order to enable HTTP2, we can do curl_setopt($ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_2_0);.

Don't we need a corresponding call for v3? CURL_HTTP_VERSION_3 does not exist, is that intended?

Maybe we're supposed to use CURLALTSVC_H3 instead?

PHP Version

PHP 8.3
@adoy
Copy link
Member

adoy commented Jul 21, 2023 •
edited
Loading

I'm out for vacations without a proper access to a computer until july 31th. I'll have a look at that time.

@damianwadley
Copy link
Member

https://curl.se/libcurl/c/symbols-in-versions.html

I don't see a "CURL_HTTP_VERSION_3_0".

@nicolas-grekas nicolas-grekas changed the title Missing CURL_HTTP_VERSION_3_0 constant Missing CURL_HTTP_VERSION_3 constant Jul 21, 2023
@nicolas-grekas
Copy link
Contributor Author

Updated, the name is CURL_HTTP_VERSION_3 indeed.

adoy added a commit to adoy/php-src that referenced this issue Aug 19, 2023
@adoy
Fix phpGH-11755: Expose CURL_HTTP_VERSION_3 constant
22a5807
@nicolas-grekas
Copy link
Contributor Author

Related: https://php.watch/articles/php-curl-http3 by @Ayesh

@Ayesh
Copy link
Member

Ayesh commented Feb 22, 2024

Ping :)

@Ayesh
Copy link
Member

Ayesh commented Aug 13, 2024

Hi @nicolas-grekas - we recently had #15350 merged, so PHP 8.4 will have CURL_HTTP_VERSION_3 and CURL_HTTP_VERSION_3ONLY constants declared (subject to underlying libcurl version). Shall we close this?

@nicolas-grekas
Copy link
Contributor Author

Sure, thanks for the help!

@hostep hostep mentioned this issue Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adoy adoy

Labels
Extension: curl Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@adoy @bukka @nicolas-grekas @Ayesh @Girgias @damianwadley