Set of opcache tests fail zts+aarch64 8.4.1 #16902

andypost · 2024-11-23T00:38:02Z

Description

Building ZTS packages for Alpinelinux for 8.4.1 I got a set of failed tests and all of them related to opcache

ref https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1615413

# JIT and OpCache related tests to disable
ext/opcache/tests/bug81272.phpt
ext/opcache/tests/gh16186_001.phpt
ext/opcache/tests/gh16186_002.phpt
ext/opcache/tests/jit/assign_obj_002.phpt
ext/opcache/tests/jit/bool_not_001.phpt
ext/opcache/tests/jit/bug77857.phpt
ext/opcache/tests/jit/bug79888.phpt
ext/opcache/tests/jit/bug80634.phpt
ext/opcache/tests/jit/bug80745.phpt
ext/opcache/tests/jit/bug80786.phpt
ext/opcache/tests/jit/bug80802.phpt
ext/opcache/tests/jit/bug80839.phpt
ext/opcache/tests/jit/bug80861.phpt
ext/opcache/tests/jit/bug80959.phpt
ext/opcache/tests/jit/bug81051.phpt
ext/opcache/tests/jit/bug81225.phpt
ext/opcache/tests/jit/bug81225_2.phpt
ext/opcache/tests/jit/bug81226.phpt
ext/opcache/tests/jit/bug81249.phpt
ext/opcache/tests/jit/bug81255.phpt
ext/opcache/tests/jit/bug81256.phpt
ext/opcache/tests/jit/bug81409.phpt
ext/opcache/tests/jit/cast_001.phpt
ext/opcache/tests/jit/defined_001.phpt
ext/opcache/tests/jit/fetch_dim_r_005.phpt
ext/opcache/tests/jit/fetch_obj_005.phpt
ext/opcache/tests/jit/gh12380.phpt
ext/opcache/tests/jit/gh15490.phpt
ext/opcache/tests/jit/gh8461-001.phpt
ext/opcache/tests/jit/gh8461-002.phpt
ext/opcache/tests/jit/gh8461-003.phpt
ext/opcache/tests/jit/gh8461-004.phpt
ext/opcache/tests/jit/gh8461-005.phpt
ext/opcache/tests/jit/gh8461-006.phpt
ext/opcache/tests/jit/gh8461-007.phpt
ext/opcache/tests/jit/gh8461-008.phpt
ext/opcache/tests/jit/gh8591-001.phpt
ext/opcache/tests/jit/gh8591-002.phpt
ext/opcache/tests/jit/gh8591-003.phpt
ext/opcache/tests/jit/gh8591-004.phpt
ext/opcache/tests/jit/gh8591-005.phpt
ext/opcache/tests/jit/gh8591-006.phpt
ext/opcache/tests/jit/hot_func_002.phpt
ext/opcache/tests/jit/ignored_opcodes.phpt
ext/opcache/tests/jit/init_fcall_003.phpt
ext/opcache/tests/jit/loop_002.phpt
ext/opcache/tests/jit/mod_003.phpt
ext/opcache/tests/jit/mul_005.phpt
ext/opcache/tests/jit/oss-fuzz-64727.phpt
ext/opcache/tests/jit/reg_alloc_004.phpt
ext/opcache/tests/jit/trampoline_001.phpt
ext/opcache/tests/jit/trampoline_002.phpt

PHP Version

PHP 8.4.1

Operating System

Alpinelinux

The text was updated successfully, but these errors were encountered:

andypost · 2024-11-23T00:41:25Z

it fail only on aarch64

TEST 10325/18580 [ext/opcache/tests/jit/reg_alloc_004.phpt]
========DIFF========
--
     Warning: Undefined variable $d in %sreg_alloc_004.php on line 7
     
     Warning: Undefined variable $d in %sreg_alloc_004.php on line 7
008- 
009- Fatal error: Uncaught Error: First array member is not a valid class name or object in %sreg_alloc_004.php:7
010- Stack trace:
011- #0 %sreg_alloc_004.php(7): createTree(0)
012- #1 %sreg_alloc_004.php(7): createTree(1)
013- #2 %sreg_alloc_004.php(7): createTree(2)
014- #3 %sreg_alloc_004.php(9): createTree(3)
015- #4 {main}
016-   thrown in %sreg_alloc_004.php on line 7
========DONE========
FAIL Register Alloction 004: Check guard before register load [ext/opcache/tests/jit/reg_alloc_004.phpt] 

TEST 10365/18580 [ext/opcache/tests/jit/trampoline_001.phpt]
========DIFF========
001- BBBCCC
001+ B
========DONE========
FAIL JIT Trampoline 001: trampoline cleanup [ext/opcache/tests/jit/trampoline_001.phpt] 
TEST 10366/18580 [ext/opcache/tests/jit/trampoline_002.phpt]
========DIFF========
001- BBBCCCDDDCCC
001+ B
========DONE========
FAIL JIT Trampoline 002: trampoline cleanup [ext/opcache/tests/jit/trampoline_002.phpt]

andypost · 2024-11-23T00:45:05Z

TEST 10300/18580 [ext/opcache/tests/jit/oss-fuzz-64727.phpt]
========DIFF========
001- int(0)
002- int(3)
003- int(3)
004- NULL
001+ 
========DONE========
FAIL oss-fuzz #64727 [ext/opcache/tests/jit/oss-fuzz-64727.phpt]

nielsdos · 2024-11-23T15:28:14Z

Hm, this could be related to the TSRM cache tcb offset, if this is not fully supported on ARM64+MUSL.
Just to be clear: this does work on versions lower than 8.4 ? Does a debug build give any assertion failure?

andypost · 2024-11-23T22:36:48Z

Previously I did not build zts so no previous state, debug -g was added but I did not debug yet, strange that it pass on loongarch64 and armv7/hf(32-bit)

andypost · 2024-11-23T22:38:35Z

building with --enable-debug-assertions

andypost · 2024-11-23T23:48:42Z

Yes, there's assertions now

TEST 10365/18580 [ext/opcache/tests/jit/trampoline_001.phpt]
========DIFF========
001- BBBCCC
001+ Assertion failed: tsrm_ls_cache_tcb_offset != 0 (ext/opcache/jit/zend_jit_ir.c: zend_jit_setup: 3237)
========DONE========
FAIL JIT Trampoline 001: trampoline cleanup [ext/opcache/tests/jit/trampoline_001.phpt] 
TEST 10366/18580 [ext/opcache/tests/jit/trampoline_002.phpt]
========DIFF========
001- BBBCCCDDDCCC
001+ Assertion failed: tsrm_ls_cache_tcb_offset != 0 (ext/opcache/jit/zend_jit_ir.c: zend_jit_setup: 3237)
========DONE========
FAIL JIT Trampoline 002: trampoline cleanup [ext/opcache/tests/jit/trampoline_002.phpt]

andypost · 2024-11-23T23:50:59Z

all of them are the same!

TEST 10026/18580 [ext/opcache/tests/jit/assign_dim_003.phpt]
========DIFF========
001- Warning: Undefined variable $v in %sassign_dim_003.php on line 3
002- NULL
001+ Assertion failed: tsrm_ls_cache_tcb_offset != 0 (ext/opcache/jit/zend_jit_ir.c: zend_jit_setup: 3237)
========DONE========
FAIL JIT ASSIGN_DIM: 003 [ext/opcache/tests/jit/assign_dim_003.phpt]

nielsdos · 2024-11-24T10:17:09Z

Thanks! Right, so my suspicion that this is missing MUSL TSRM TLS support is right.
Annoyingly I don't have Arm64 hardware, but I can look into this maybe via emulation...

nielsdos · 2024-11-24T13:20:28Z

@andypost Can you please try the following patch? https://gist.github.com/nielsdos/acdcc7c3cab51d42df6eec41f50eb5e3
This fixes the issue for me. This applies on PHP-8.4. Lower branches (i.e. versions below 8.4) will need a slightly different patch.

andypost · 2024-11-24T14:11:52Z

Thank you, I will try as php.net will be back

andypost · 2024-11-24T18:29:29Z

@nielsdos Thank you a lot! now it passed all tests!

nielsdos · 2024-11-24T18:33:13Z

Thanks for checking @andypost , now I need to split this into different PRs because one part needs to go in php-src and another one in https://github.com/dstogov/ir

This is the IR part of php/php-src#16902.

Accompanying IR PR: dstogov/ir#95

andypost · 2024-11-24T20:10:55Z

Attempted 8.3 build and it has more failures, moreover lots fails on 32-bits

nielsdos · 2024-11-24T20:19:27Z

@andypost This is the patch that should fix ZTS+JIT+Aarch64 on Alpine for PHP 8.2 and 8.3: #16925

Can you link also the 32-bit failures? Do you mean x86 32 bit or ARM 32 bit? Only the former has JIT.

nielsdos · 2024-11-24T20:20:00Z

Note that I force pushed this 8.2-8.3 PR a few minutes ago, so if you had tested in the meantime I have updated the patch

andypost · 2024-11-24T22:18:38Z

Thank you! ARM passed, the only x86 (32-bit) failure

TEST 6756/17235 [ext/ffi/tests/gh14626.phpt]
========DIFF========
001- ==DONE==
001+ zend_mm_heap corrupted
========DONE========
FAIL GH-14626: FFI::free() may crash in is_zend_ptr() when at least one huge block exists and the ptr is non-zend [ext/ffi/tests/gh14626.phpt]

This is the IR part of php/php-src#16902.

andypost · 2024-11-25T14:18:21Z

@nielsdos many thanks! all arches passed, btw x86 failure is random somehow
Probably MM issue on musl still exist and I gonna explore https://frankenphp.dev/docs/performance/#dont-use-musl

andypost · 2024-11-25T15:20:27Z

Can you link also the 32-bit failures?

often fails on 32-bits both arm and x86

TEST 6757/17242 [ext/ffi/tests/gh14626.phpt]
========DIFF========
001- ==DONE==
001+ zend_mm_heap corrupted
========DONE========
FAIL GH-14626: FFI::free() may crash in is_zend_ptr() when at least one huge block exists and the ptr is non-zend [ext/ffi/tests/gh14626.phpt]

and this one I even disabled for few arches as it very unstable

TEST 6130/17242 [ext/dba/tests/dba_gdbm.phpt]
========DIFF========
--
     bool(true)
     Try to remove key 1 again
     bool(false)
013- key4: Another Content String
013+ [key30]name30: Content String 30
014+ key5: The last content string
015+ name9: Content String 9
     key2: Content String 2
015- key5: The last content string
     [key10]name10: Content String 10
017- name9: Content String 9
018- [key30]name30: Content String 30
018+ key4: Another Content String
     Total keys: 6
     Key 1 exists? N
     Key 2 exists? Y
--
     bool(true)
     Try to remove key 1 again
     bool(false)
059- key4: Another Content String
059+ [key30]name30: Content String 30
060+ key5: The last content string
061+ name9: Content String 9
     key2: Content String 2
061- key5: The last content string
     [key10]name10: Content String 10
063- name9: Content String 9
064- [key30]name30: Content String 30
064+ key4: Another Content String
     Total keys: 6
     Key 1 exists? N
     Key 2 exists? Y
--
========DONE========
FAIL DBA GDBM handler test [ext/dba/tests/dba_gdbm.phpt]

* PHP-8.2: Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

* PHP-8.3: Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

Accompanying IR PR: dstogov/ir#95 Closes GH-16924.

* PHP-8.4: Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.4+) Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

nielsdos · 2024-11-25T18:54:38Z

@andypost I fixed the ZTS issue, hence this issue was closed.

About your other two issues:

I'll try to have a look at the FFI issue, I need to setup a Docker container for i386 Alpine though so that may take a little bit.
The gdbm issue is actually this: ext/dba/tests: sort expected test output #14962 It turns out that the test file was missing a sort. I'll ask in that PR if this should be backported.

nielsdos · 2024-11-25T19:53:12Z

@andypost I can reproduce that FFI issue but have not fully understood it yet. I know that the reason for the crash is that is_zend_ptr() for some reason returned 1 instead of 0, I'm debugging further...

We should compare the block memory, not the block metadata (See zend_mm_add_huge_block). This caused random test failure for ext/ffi/tests/gh14626.phpt when the malloc() performed by the FFI code lies close to the block metadata, and the size of the block is large enough. This was reported by php#16902 (comment)

nielsdos · 2024-11-25T20:25:12Z

@andypost I have identified the problem and propose this patch: #16938

We should compare the block memory, not the block metadata (See zend_mm_add_huge_block). This caused random test failure for ext/ffi/tests/gh14626.phpt when the malloc() performed by the FFI code lies close to the block metadata, and the size of the block is large enough. This was reported by #16902 (comment) Closes GH-16938.

nielsdos · 2024-11-26T20:25:40Z

@andypost Everything you reported, including that gdbm issue, should now be fixed in the next releases of 8.2,8.3,8.4.

andypost · 2024-11-26T20:29:48Z

@nielsdos Thank you a lot!

I'm waiting for RC1 releases to start with ZTS!

andypost added Bug Status: Needs Triage labels Nov 23, 2024

nielsdos added Category: JIT Status: Verified Category: TSRM OS: Alpine / Musl and removed Status: Needs Triage labels Nov 24, 2024

nielsdos self-assigned this Nov 24, 2024

nielsdos mentioned this issue Nov 24, 2024

Disable tsrm_ls_cache usage on Cygwin #16920

Closed

nielsdos added a commit to nielsdos/ir that referenced this issue Nov 24, 2024

Add support for MUSL AArch64 TLS

b3eb5db

This is the IR part of php/php-src#16902.

nielsdos mentioned this issue Nov 24, 2024

Add support for MUSL AArch64 dynamic TLS dstogov/ir#95

Merged

nielsdos added a commit to nielsdos/php-src that referenced this issue Nov 24, 2024

Fix phpGH-16902: Set of opcache tests fail zts+aarch64 (8.4+)

c561f08

Accompanying IR PR: dstogov/ir#95

nielsdos linked a pull request Nov 24, 2024 that will close this issue

Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.4+) #16924

Closed

andypost mentioned this issue Nov 24, 2024

PHP Version 8.4 remicollet/remirepo#258

Closed

nielsdos mentioned this issue Nov 24, 2024

Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.4+) #16924

Closed

nielsdos added a commit to nielsdos/php-src that referenced this issue Nov 24, 2024

Fix phpGH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

66efadd

nielsdos added a commit to nielsdos/php-src that referenced this issue Nov 24, 2024

Fix phpGH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

32284e1

dstogov pushed a commit to dstogov/ir that referenced this issue Nov 25, 2024

Add support for MUSL AArch64 TLS (#95)

ff7ee6c

This is the IR part of php/php-src#16902.

nielsdos added a commit that referenced this issue Nov 25, 2024

Merge branch 'PHP-8.2' into PHP-8.3

d50a561

* PHP-8.2: Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

nielsdos added a commit that referenced this issue Nov 25, 2024

Merge branch 'PHP-8.3' into PHP-8.4

8e57df2

* PHP-8.3: Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

nielsdos added a commit that referenced this issue Nov 25, 2024

Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.4+)

f4ca6d2

Accompanying IR PR: dstogov/ir#95 Closes GH-16924.

nielsdos closed this as completed in de96b43 Nov 25, 2024

nielsdos added a commit that referenced this issue Nov 25, 2024

Merge branch 'PHP-8.4'

aa05c82

* PHP-8.4: Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.4+) Fix GH-16902: Set of opcache tests fail zts+aarch64 (8.2-8.3)

nielsdos mentioned this issue Nov 25, 2024

ext/dba/tests: sort expected test output #14962

Merged

nielsdos mentioned this issue Nov 25, 2024

Fix is_zend_ptr() huge block comparison #16938

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set of opcache tests fail zts+aarch64 8.4.1 #16902

Set of opcache tests fail zts+aarch64 8.4.1 #16902

andypost commented Nov 23, 2024

andypost commented Nov 23, 2024 •

edited

Loading

andypost commented Nov 23, 2024

nielsdos commented Nov 23, 2024

andypost commented Nov 23, 2024

andypost commented Nov 23, 2024

andypost commented Nov 23, 2024 •

edited

Loading

andypost commented Nov 23, 2024

nielsdos commented Nov 24, 2024 •

edited

Loading

nielsdos commented Nov 24, 2024

andypost commented Nov 24, 2024

andypost commented Nov 24, 2024

nielsdos commented Nov 24, 2024

andypost commented Nov 24, 2024 •

edited

Loading

nielsdos commented Nov 24, 2024

nielsdos commented Nov 24, 2024

andypost commented Nov 24, 2024

andypost commented Nov 25, 2024

andypost commented Nov 25, 2024

nielsdos commented Nov 25, 2024

nielsdos commented Nov 25, 2024

nielsdos commented Nov 25, 2024

nielsdos commented Nov 26, 2024

andypost commented Nov 26, 2024

Set of opcache tests fail zts+aarch64 8.4.1 #16902

Set of opcache tests fail zts+aarch64 8.4.1 #16902

Comments

andypost commented Nov 23, 2024

Description

PHP Version

Operating System

andypost commented Nov 23, 2024 • edited Loading

andypost commented Nov 23, 2024

nielsdos commented Nov 23, 2024

andypost commented Nov 23, 2024

andypost commented Nov 23, 2024

andypost commented Nov 23, 2024 • edited Loading

andypost commented Nov 23, 2024

nielsdos commented Nov 24, 2024 • edited Loading

nielsdos commented Nov 24, 2024

andypost commented Nov 24, 2024

andypost commented Nov 24, 2024

nielsdos commented Nov 24, 2024

andypost commented Nov 24, 2024 • edited Loading

nielsdos commented Nov 24, 2024

nielsdos commented Nov 24, 2024

andypost commented Nov 24, 2024

andypost commented Nov 25, 2024

andypost commented Nov 25, 2024

nielsdos commented Nov 25, 2024

nielsdos commented Nov 25, 2024

nielsdos commented Nov 25, 2024

nielsdos commented Nov 26, 2024

andypost commented Nov 26, 2024

andypost commented Nov 23, 2024 •

edited

Loading

andypost commented Nov 23, 2024 •

edited

Loading

nielsdos commented Nov 24, 2024 •

edited

Loading

andypost commented Nov 24, 2024 •

edited

Loading