Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/intl: change when the locale is invalid for the 8.1/8.2 serie. #12568

Conversation

devnexen
Copy link
Member

does not throws an exception as it's considered as a too string change, but the code user still needs to double check.

does not throws an exception as it's considered as a too string change,
but the code user still needs to double check.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan, but considering this breaks BC... can you add a note in UPGRADING for 8.3 when merging upwards?

@hormus
Copy link

hormus commented Nov 25, 2023

@Girgias please

<?php

$a = new IntlDateFormatter('C', IntlDateFormatter::FULL, IntlDateFormatter::FULL);
var_dump($a->getLocale(ULOC_VALID_LOCALE));
?>

Result:

Fatal error: Uncaught Error: Found unconstructed IntlDateFormatter in /in/qCifp:6
Stack trace:
#0 /in/qCifp(6): IntlDateFormatter->getLocale(1)
#1 {main}
  thrown in /in/qCifp on line 6

Process exited with code 255.

I would expect a notice or warning but not the fatal error. Please can you explain the usage?

@Girgias
Copy link
Member

Girgias commented Nov 27, 2023

I do not understand ICU nor am I the maintainer of ext/intl, please file a new issue instead of responding to an old PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants