fix memleak due to missing pthread_attr_destroy()
-call
#14510
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there 👋
I just added PHP 8.3 with ASAN to
ext-parallel
and it is failing. The stack traces I attached led me to the docs of thepthread_getattr_np()
call where it is stated that:The implementation of
pthread_attr_setaffinity_np()
(which is called bypthread_getattr_np()
) does some allocations, that are freed in thepthread_attr_destroy()
function, so I added this call. It looks like this code is related to #9104, so I'd appreciate a review from @arnaud-lb.With the proposed changes, ASAN in
ext-parallel
is green again. I can not rule out, that I missed something, or that I am just misusing the API in some way.This is the stack trace ASAN is showing locally: