[Basic functions] Added return type for arginfo

[ovr]

Hey!
I love PHP7 ideas about return type hints and it's very usefull in static analysis
I am working https://github.com/ovr/phpsa
Now I am using https://github.com/ovr/phpreflection but I would like to see return type for all functions in PHP7 on FunctionReflection

Now
I am going to add return types for basic functions

Dear mainterns:
If idea is rly good please write smthgs in comments :)
Because i don't know is it okey or not

Main questions:
1 http://php.net/manual/en/function.abs.php
Maybe it's time to add fake type IS_NUMBER?

Thanks

[ovr]

@nikic @laruence @dstogov

1 http://php.net/manual/en/function.abs.php
Maybe it's time to add fake type IS_NUMBER?

[dstogov]

Hi Dmitry,

PHP-7 is in RC stage. We can't add any new features now.
We may add something like this in 7.1, and this will require RFC,
discussion, voting...

Thanks. Dmitry.

On Sun, Aug 30, 2015 at 7:22 PM, Dmitry Patsura notifications@github.com
wrote:

@nikic https://github.com/nikic @laruence https://github.com/laruence
@dstogov https://github.com/dstogov

1 http://php.net/manual/en/function.abs.php
Maybe it's time to add fake type IS_NUMBER?

—
Reply to this email directly or view it on GitHub
#1492 (comment).

[krakjoe]

Since no RFC has materialized, and since the work seems to have been abandoned by the author, I'm closing this PR.

Take this as encouragement to create a clean, complete PR, targeting an appropriate branch (too late for 7.1), and start an accompanying RFC and internals discussion at the same time.

[dstogov]

BTW: I don't see a problem merging this PR into master.

[carusogabriel]

@morrisonlevi Was this you were talking about #3026 (comment)?

[krakjoe]

@dstogov quote:

PHP-7 is in RC stage. We can't add any new features now.
We may add something like this in 7.1, and this will require RFC,
discussion, voting...

Was this in reference to the suggestion to add IS_NUMBER ?

[dstogov]

@krakjoe yes

[krakjoe]

Merged b7d2e04

Thanks.

Apologies for the confusion ...

[krakjoe]

Reverted because the use of macro is wrong since we changed to use zend_type ...

@ovr please update for current master ...

If @ovr doesn't respond in the next week or so, I'll do it again myself ...

[ovr]

Rebased commits, drop unneeded argument on ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO & ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX

[nikic]

All of these will need to be declared nullable due to zpp failures :(

[morrisonlevi]

@nikic I think it would be better for the future if we distinguish at the macro level the functions returning nullable types because of ZPP failures and those which may return null even if ZPP failure is changed to TypeError. Unless we don't have any of those; I know returning false is incredibly common. Agree?

[morrisonlevi]

@nikic @krakjoe bump on this.

[carusogabriel]

@morrisonlevi @nikic @krakjoe Is functions return type something that might be happening in PHP 7.x? Is so, I've started to write a script (it is very simple yet), so we can automate that. Let me know if you want me to PR it to the core, so we can start adding them 😄

[cmb69]

I don't think it makes much sense to add return type arginfo, if we're not also adding parameter type arginfo. Furthermore, adding return type arginfo is a general problem as pointed out above, since ZPP failures are handled manually (most functions return NULL in this case, but I've seen functions returning FALSE). It might be most reasonable to postpone this to PHP 8, where we hopefully can throw exceptions on ZPP failures, and maybe even unify arginfo and ZPP.

[krakjoe]

@ovr bump, see nikita's comment ...

[php-pulls]

Comment on behalf of kalle at php.net:

Closing due to inactivity