Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/curl: mark certain tests as xfail on curl 8.10.0 #16007

Closed
wants to merge 1 commit into from
Closed

ext/curl: mark certain tests as xfail on curl 8.10.0 #16007

wants to merge 1 commit into from

Conversation

Ayesh
Copy link
Member

@Ayesh Ayesh commented Sep 23, 2024

Related: #15997

@Ayesh Ayesh requested a review from adoy as a code owner September 23, 2024 13:11
@Ayesh Ayesh mentioned this pull request Sep 23, 2024
Closed
@Ayesh Ayesh force-pushed the curl-8-10-0-test-skip branch from a3a951f to 857bbd0 Compare September 23, 2024 13:13
@Ayesh Ayesh force-pushed the curl-8-10-0-test-skip branch from 857bbd0 to 6184190 Compare September 23, 2024 13:22
@TimWolla
Copy link
Member

Should this also be applied to the older branches, which might also receive the macOS updates?

@Ayesh
Copy link
Member Author

Ayesh commented Sep 23, 2024

You are right we probably should target 8.2 branch. If tests pass, I will change to 8.2 branch. Thank you @TimWolla

@cmb69
Copy link
Member

cmb69 commented Sep 23, 2024

@Ayesh, no need to change the base branch. The patch should apply cleanly to PHP 8.2 anyway.

@Ayesh
Copy link
Member Author

Ayesh commented Sep 23, 2024

Thank you. If we were to merge this, I'd appreciate if you could cherry-pick this on other branches so we don't have to run CI again.

@cmb69
Copy link
Member

cmb69 commented Sep 23, 2024

I usually follow https://wiki.php.net/vcs/gitworkflow#merge_a_pull_request anyway. :)

@Ayesh
Copy link
Member Author

Ayesh commented Sep 23, 2024

Even better 🚀. Thank you! CI finally passed (except for the unrelated mysql service issue).

@cmb69 cmb69 closed this in 0bdc4b8 Sep 23, 2024
@cmb69
Copy link
Member

cmb69 commented Sep 23, 2024

Thank you, @Ayesh!

@Ayesh Ayesh deleted the curl-8-10-0-test-skip branch September 23, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adoy adoy Awaiting requested review from adoy adoy is a code owner

Assignees
No one assigned
Labels
Extension: curl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayesh @TimWolla @cmb69