Allow JIT for passing arguments to trampolines and "bad" functions #16365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstogov
force-pushed
the
jit_trampoline
branch
from
9a403e4 to
171049b
Compare
arnaud-lb
reviewed
Oct 15, 2024
| zend_jit_op_array_trace_extension *jit_extension; | ||
|
|
||
| if (EX(call)->func->common.fn_flags & ZEND_ACC_CALL_VIA_TRAMPOLINE) { |
There was a problem hiding this comment.
I think that we need similar changes in zend_jit_trace_record_fake_init_call_ex(), otherwise this code is mis-compiled when ++$arg triggers a side trace:
class Test {
public mixed $prop;
function foo($args) {
foreach ($args as $arg) {
$this->bar(++$arg);
}
}
function __call($name, $args) {
}
}
$test = new Test;
$test->foo([1, 1.5, 1.5]);There was a problem hiding this comment.
Thanks for catching! I'll fix this.
It may be caused by SEND_UNPACK/SEND_ARRAY
dstogov
force-pushed
the
jit_trampoline
branch
from
171049b to
b2cf43a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.