Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 release page #807

Merged
merged 36 commits into from
Nov 21, 2023
Merged

PHP 8.3 release page #807

merged 36 commits into from
Nov 21, 2023

Conversation

saundefined
Copy link
Member

@saundefined saundefined commented Aug 26, 2023

  • Update logo
  • Finish the English version
  • Put messages in lang-files
  • Add links to Documentation
  • Merge PR without updates in include/header.inc and index.php
  • Waiting for the release of PHP 8.3 🎉
  • Update include/header.inc and index.php (PHP 8.3 released! #825)

Any help and suggestions are welcomed :)

Preview: https://php.sergeypanteleev.com/releases/8.3/en.php

@saundefined saundefined self-assigned this Aug 26, 2023
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions to the code blocks to make wrapping explicit and the blocks more readable.

releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Show resolved Hide resolved
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, code blocks are looking good now. I'll probably will write some short description for the Override and Randomizer stuff later, because while the code examples are good, I don't think they are sufficient to properly highlight the new features 😄

releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
@bukka
Copy link
Member

bukka commented Nov 2, 2023

I would say that json_validate is probably one of the bigger feature in 8.3 so it should go at least above Randomizer ones which I'm not sure we should be mention in such detail. Surely introducing Randomizer was worth to mentioning as it was a big thing but adding some extra less used methods for likely small number of use cases should not be mentioned in such detail IMHO.

I would keep all the engine features first and then maybe some note about json_validate and Randomizer withtout too detailed examples.

@TimWolla
Copy link
Member

TimWolla commented Nov 3, 2023

It's got a small issue though - the name is so long that it doesn't look good on mobile - maybe smaller font should be used.

Added suggestion to fix this.

Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more suggestions

releases/8.3/release.inc Show resolved Hide resolved
releases/8.3/release.inc Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Show resolved Hide resolved
releases/8.3/release.inc Show resolved Hide resolved
releases/8.3/release.inc Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
@saundefined
Copy link
Member Author

saundefined commented Nov 17, 2023

So, I'm going to merge this PR on Tuesday (November 21),
I've removed links to the PHP 8.3 page in the ac55c2b commit and will add them in a separate PR.

On Thursday (November 23), along with the release of PHP 8.3, we will merge the second PR.

During this time we can check that everything is displaying correctly and make any adjustments if needed.

Feel free to suggest fixes now if you see fit :)

saundefined and others added 2 commits November 17, 2023 22:16
Co-authored-by: Tim Bond <cookieguru@gmail.com>
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/release.inc Outdated Show resolved Hide resolved
releases/8.3/languages/en.php Outdated Show resolved Hide resolved
releases/8.3/languages/en.php Outdated Show resolved Hide resolved
releases/8.3/languages/en.php Outdated Show resolved Hide resolved
releases/8.3/languages/en.php Outdated Show resolved Hide resolved
releases/8.3/languages/en.php Outdated Show resolved Hide resolved
saundefined and others added 3 commits November 18, 2023 15:51
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
@pronskiy
Copy link
Contributor

It would be nice to mention the stack overflow detection php/php-src#9104
/cc @arnaud-lb

@saundefined saundefined merged commit 636b1db into php:master Nov 21, 2023
1 of 2 checks passed
@saundefined saundefined deleted the php83 branch November 21, 2023 10:14
@Flote37
Copy link
Contributor

Flote37 commented Nov 21, 2023

Hi @saundefined,
Thanks for this release page, it is really useful to catch up with PHP new feature.

I found a small link issue in the 8.3 release page (https://www.php.net/releases/8.3/en.php)
The link to the new "stream_context_set_options" function redirects to the old one (the one without the ending "s").
We have "https://www.php.net/manual/en/function.stream-context-set-option.php" instead of "https://www.php.net/manual/en/function.stream-context-set-options.php"

As this issue is already "merged", should I create a new issue ?

@cookieguru
Copy link
Contributor

@Flote37 just open a PR to fix it

@Flote37
Copy link
Contributor

Flote37 commented Nov 21, 2023

@cookieguru is this ok ? #827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants