-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.3 release page #807
PHP 8.3 release page #807
Conversation
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions to the code blocks to make wrapping explicit and the blocks more readable.
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, code blocks are looking good now. I'll probably will write some short description for the Override and Randomizer stuff later, because while the code examples are good, I don't think they are sufficient to properly highlight the new features 😄
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Add PHP 8.3 logo
I would say that I would keep all the engine features first and then maybe some note about json_validate and Randomizer withtout too detailed examples. |
Added suggestion to fix this. |
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more suggestions
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
So, I'm going to merge this PR on Tuesday (November 21), On Thursday (November 23), along with the release of PHP 8.3, we will merge the second PR. During this time we can check that everything is displaying correctly and make any adjustments if needed. Feel free to suggest fixes now if you see fit :) |
Co-authored-by: Tim Bond <cookieguru@gmail.com>
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
Co-authored-by: Tim Düsterhus <tim@bastelstu.be>
It would be nice to mention the stack overflow detection php/php-src#9104 |
Hi @saundefined, I found a small link issue in the 8.3 release page (https://www.php.net/releases/8.3/en.php) As this issue is already "merged", should I create a new issue ? |
@Flote37 just open a PR to fix it |
@cookieguru is this ok ? #827 |
include/header.inc
andindex.php
include/header.inc
andindex.php
(PHP 8.3 released! #825)Any help and suggestions are welcomed :)
Preview: https://php.sergeypanteleev.com/releases/8.3/en.php