Add support for never keyword #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvriel
reviewed
Sep 17, 2021
php 8.1 introduces the `never` keyword, which can be used as return type.
|
Yes, `never` is a native type.
CRB
…On Fri, Sep 17, 2021, 10:11 Mike van Riel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/Types/Never_.php
<#130 (comment)>
:
> +
+/**
+ * This file is part of phpDocumentor.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * @link http://phpdoc.org
+ */
+
+namespace phpDocumentor\Reflection\Types;
+
+use phpDocumentor\Reflection\Type;
+
+/**
+ * Value Object representing the pseudo-type 'void'.
Also, never is not a pseudo-type, right? It will be an actual type?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#130 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAYOSQ5EPEIP7E3CTGMIMLUCNLC3ANCNFSM5EHQMM4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
jaapio
force-pushed
the
feature/never_type
branch
from
5d0f6d9
to
17726a3
Compare
Void and never are types that can only be used for function return types. Officially php doesn't have a category of types that are only allowed for return, but I think it makes sense to name them like this.
|
I named it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php 8.1 introduces the
neverkeyword, which can be used as return type.