Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues found using dennis #2

Merged
merged 1 commit into from
Oct 12, 2016
Merged

Fix issues found using dennis #2

merged 1 commit into from
Oct 12, 2016

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 12, 2016

No description provided.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 12, 2016

The current list of warnings and errors found by dennis can be seen at : https://travis-ci.org/jayvdb/localized_docs/builds/167009605

If desired, I can also submit a .travis.yml that is green: https://travis-ci.org/jayvdb/localized_docs/builds/167012787
There are still some warnings, but often they need to be fixed in the English, or need to be ignored with a feature like mozilla/dennis#80 .

@nijel nijel self-assigned this Oct 12, 2016
@nijel nijel merged commit 238bd3d into phpmyadmin:master Oct 12, 2016
@nijel
Copy link
Contributor

nijel commented Oct 12, 2016

Thanks! Having .travis check for this is good idea, PR is welcome.

This was referenced Oct 12, 2016
Closed
Closed
jayvdb
jayvdb commented Oct 12, 2016
View reviewed changes
po/tr.po
@@ -16689,7 +16689,7 @@ msgstr ""
"Ayrıca, sorgunun içerisinde, değerler için yer tutuculara sahip "
"olabilirsiniz. Bu, sorgu içerisine ``/*`` ve ``*/`` arasına SQL açıklamaları "
"eklenerek yapılır. Açıklamaların içerisinde, özel dizgiler "
"``[DEĞİŞKEN{değişken-numarası}]`` kullanılır. SQL açıklamalarından çıkarılan "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nijel , should this be translated?

po/fr.po
@@ -17032,7 +17032,7 @@ msgstr ""
"Vous pouvez aussi avoir, à l'intérieur d'une requête, des espaces réservés "
"pour des variables. Ceci est effectué en insérant dans la requête un "
"commentaire SQL entre ``/*`` et ``*/``. Dans le commentaire, la chaîne "
"spéciale ``[VARIABLE{numéro de variable}]`` est utilisée. Gardez à l'esprit "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nijel , should this be translated?

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 12, 2016

@nijel, ok, I will submit a .travis.yml soon.

I suspect that [VARIABLE{variable-number}] should be translated, and I think I know how to prevent it being a dennis error.

@nijel
Copy link
Contributor

nijel commented Oct 12, 2016

It's fine to translate it.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 12, 2016

Ok, I'll fiddle with dennis to allow that, and then revert those edits in this commit.
As an aside, I am using this project in an training program/competition.
You can read about the task at https://wikimedia-id.github.io/besutkode/university-sample-task-1-en.html

@nijel
Copy link
Contributor

nijel commented Oct 13, 2016

Thanks! Is the competition somehow open to the public? If so, we could promote it on our social media as well...

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 13, 2016

Open only to Indonesian uni students, and registration closes in a few days. Thanks for your offer, but I doubt you would reach anyone who we havent already reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @nijel