Refactor

spec/Util/StrSpec.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace spec\GrumPHP\Util;
+
+use PhpSpec\ObjectBehavior;
+
+class StrSpec extends ObjectBehavior
+{
+    function it_should_find_a_part_of_a_string_by_one_of_the_provided_needles()
+    {
+        $this::containsOneOf('a;randomText-written by me', ['a', 'me'])->shouldBe(true);
+        $this::containsOneOf('a;randomText-written by me', ['Text'])->shouldBe(true);
+
+        $this::containsOneOf('a;randomText-written by me', ['this does not exist'])->shouldBe(false);
+        $this::containsOneOf('a;randomText-written by me', ['text'])->shouldBe(false);
+    }
+
+    function it_should_split_a_string_by_a_delimiter_and_result_in_a_unique_list()
+    {
+        $this::explodeWithCleanup(',', ' a random,list, of things ')->shouldBe([
+            'a random', 'list', 'of things'
+        ]);
+    }
+}

src/Console/Command/RunCommand.php

@@ -11,6 +11,7 @@
 use GrumPHP\Locator\RegisteredFiles;
 use GrumPHP\Runner\TaskRunnerContext;
 use GrumPHP\Task\Context\RunContext;
+use GrumPHP\Util\Str;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
 use Symfony\Component\Console\Input\InputOption;
@@ -68,7 +69,7 @@ public function execute(InputInterface $input, OutputInterface $output)
         $files = $this->getRegisteredFiles();
         $testSuites = $this->grumPHP->getTestSuites();
 
-        $tasks = $this->parseCommaSeparatedOption($input->getOption("tasks") ?? "");
+        $tasks = Str::explodeWithCleanup(',', $input->getOption("tasks") ?? '');
 
         $context = new TaskRunnerContext(
             new RunContext($files),
@@ -93,25 +94,4 @@ protected function paths(): PathsHelper
     {
         return $this->getHelper(PathsHelper::HELPER_NAME);
     }
-
-    /**
-     * Split $value on ",", trim the individual parts and
-     * de-deduplicate the remaining values
-     *
-     * @param string $value
-     * @return string[]
-     */
-    protected function parseCommaSeparatedOption(string $value)
-    {
-        $stringValues = explode(",", $value);
-        $parsedValues = [];
-        foreach ($stringValues as $k => $v) {
-            $v = trim($v);
-            if (empty($v)) {
-                continue;
-            }
-            $parsedValues[] = $v;
-        }
-        return $parsedValues;
-    }
 }

src/Util/Str.php

@@ -2,16 +2,12 @@
 
 namespace GrumPHP\Util;
 
-class Str
+final class Str
 {
     /**
      * String contains one of the provided needles
-     *
-     * @param string $haystack
-     * @param array $needles
-     * @return bool
      */
-    public static function containsOneOf($haystack, array $needles)
+    public static function containsOneOf(string $haystack, array $needles): bool
     {
         foreach ($needles as $needle) {
             if ($needle !== '' && mb_strpos($haystack, $needle) !== false) {
@@ -21,4 +17,15 @@ public static function containsOneOf($haystack, array $needles)
 
         return false;
     }
+
+    /**
+     * Split $value on ",", trim the individual parts and
+     * de-deduplicate the remaining values
+     */
+    public static function explodeWithCleanup(string $delimiter, string $value): array
+    {
+        return array_unique(array_map(function (string $value) {
+            return trim($value);
+        }, explode($delimiter, $value)));
+    }
 }