Removed the unclear debug param

phpro · Apr 19, 2019 · ac14a1d · ac14a1d
1 parent 836667e
commit ac14a1d
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 21 deletions.
diff --git a/doc/tasks/paratest.md b/doc/tasks/paratest.md
@@ -80,13 +80,6 @@ The PHPUnit configuration file to use.
 
 Runner, WrapperRunner or SqliteRunner. (Default: Runner)
 
-**debugger**
-
-*Default: null*
-
-Debugger settings for code coverage.
-It can have a bin and a args key. These can be used to set the debug binary and additional arguments.
-
 **coverage-xml**
 
 *Default: null*

diff --git a/src/Task/Paratest.php b/src/Task/Paratest.php
@@ -4,7 +4,6 @@
 
 namespace GrumPHP\Task;
 
-use GrumPHP\Collection\ProcessArgumentsCollection;
 use GrumPHP\Runner\TaskResult;
 use GrumPHP\Runner\TaskResultInterface;
 use GrumPHP\Task\Context\ContextInterface;
@@ -31,7 +30,6 @@ public function getConfigurableOptions(): OptionsResolver
                 'always_execute' => false,
                 'group'          => [],
                 'runner'         => null,
-                'debugger'       => null,
                 'coverage-xml'   => null,
                 'coverage-html'  => null,
                 'log-junit'      => null,
@@ -46,7 +44,6 @@ public function getConfigurableOptions(): OptionsResolver
         $resolver->addAllowedTypes('configuration', ['null', 'string']);
         $resolver->addAllowedTypes('always_execute', ['bool']);
         $resolver->addAllowedTypes('runner', ['null', 'string']);
-        $resolver->addAllowedTypes('debugger', ['null', 'array']);
         $resolver->addAllowedTypes('coverage-xml', ['null', 'string']);
         $resolver->addAllowedTypes('coverage-html', ['null', 'string']);
         $resolver->addAllowedTypes('log-junit', ['null', 'string']);
@@ -65,7 +62,7 @@ public function run(ContextInterface $context): TaskResultInterface
         $config = $this->getConfiguration();
 
         $files = $context->getFiles()->name('*.php');
-        if (!$config['always_execute'] && 0 === \count($files)) {
+        if (!$config['always_execute'] && 0 === count($files)) {
             return TaskResult::createSkipped($this, $context);
         }
 
@@ -81,16 +78,6 @@ public function run(ContextInterface $context): TaskResultInterface
         $arguments->addOptionalArgument('--testsuite %s', $config['testsuite']);
         $arguments->addOptionalCommaSeparatedArgument('--group=%s', $config['group']);
 
-        $coverageEnabled = !empty($config['coverage-xml'])
-            || !empty($config['coverage-html'])
-            || !empty($config['log-junit']);
-
-        if ($coverageEnabled && !empty($config['debugger'])) {
-            $bin = $config['debugger']['bin'];
-            $args = $config['debugger']['args'];
-            $arguments = new ProcessArgumentsCollection(array_merge([$bin], $args, $arguments->toArray()));
-        }
-
         $process = $this->processBuilder->buildProcess($arguments);
         $process->run();