Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grouping of output in GitHub Actions #1074

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

jackbentley
Copy link
Contributor

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? ?
Deprecations? no
Documented? ?
Fixed tickets

This will add groups to the output when running in GitHub Actions.

@jackbentley jackbentley force-pushed the feature/github-actions-groups branch from 8278d35 to 5a2bed6 Compare March 21, 2023 12:20
@veewee
Copy link
Contributor

veewee commented Mar 22, 2023

Hello,

Thanks for the PR - it looks quite nice at first sight - yet it seems to fail CI.
Can you take a look at whats going wrong?

@jackbentley
Copy link
Contributor Author

Should be good now. I was passing a string instead of array to ->write in the GitHub Actions specific class

Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool feature, thanks!
Could you add some additional tests in the newly added IO classes?

@veewee veewee added this to the 1.16.0 milestone Mar 23, 2023
@veewee veewee removed this from the 1.16.0 milestone Apr 27, 2023
@veewee veewee changed the base branch from master to v2.x June 18, 2023 13:29
@veewee
Copy link
Contributor

veewee commented Sep 29, 2023

@jackbentley It's a nice feature... Care to finish up this PR? :)

@veewee veewee added this to the 2.2.0 milestone Sep 29, 2023
@veewee veewee merged commit 999fb1c into phpro:v2.x Sep 29, 2023
10 checks passed
@veewee
Copy link
Contributor

veewee commented Sep 29, 2023

Looks good, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants