Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extensions argument - fixes #1098 #1103

Merged
merged 3 commits into from
Sep 5, 2023
Merged

add extensions argument - fixes #1098 #1103

merged 3 commits into from
Sep 5, 2023

Conversation

malcomio
Copy link
Contributor

@malcomio malcomio commented Aug 3, 2023

Q A
Branch master for features and deprecations
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Documented? yes/no
Fixed tickets #1098

Use the triggered_by config option to pass to PHPMDs suffixes parameter

@malcomio malcomio mentioned this pull request Aug 3, 2023
Closed
@veewee
Copy link
Contributor

veewee commented Aug 3, 2023

Thanks for the PR. It seems about right.
Do you mind adding and changing the test-cases for this task as well?

@veewee veewee added this to the 2.1.0 milestone Sep 5, 2023
@veewee veewee merged commit affbb6c into phpro:v2.x Sep 5, 2023
@malcomio malcomio deleted the extensions branch September 6, 2023 17:07
EwenQuim pushed a commit to EwenQuim/grumphp that referenced this pull request Sep 14, 2023
@veewee @EwenQuim
Merge pull request phpro#1103 from malcomio/extensions
1bd9906 
add extensions argument - fixes phpro#1098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@malcomio @veewee