Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add task for Twig-CS-Fixer #1131

Merged
merged 6 commits into from
May 17, 2024
Merged

feat: Add task for Twig-CS-Fixer #1131

merged 6 commits into from
May 17, 2024

Conversation

antoniovj1
Copy link
Contributor

@antoniovj1 antoniovj1 commented May 14, 2024

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets

This pull request adds a task for using https://github.com/VincentLanglet/Twig-CS-Fixer/tree/main

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

doc/tasks.md Outdated Show resolved Hide resolved
@antoniovj1 antoniovj1 changed the title feat: Add task for twig-cs-fixer feat: Add task for Twig CS Fixer May 14, 2024
@antoniovj1 antoniovj1 changed the title feat: Add task for Twig CS Fixer feat: Add task for Twig-CS-Fixer May 14, 2024
Co-authored-by: Vincent Langlet <VincentLanglet@users.noreply.github.com>
doc/tasks/twigcsfixer.md Outdated Show resolved Hide resolved
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
I've added some feedback to the code.

src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
I've added some additional comments

src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
src/Task/TwigCsFixer.php Outdated Show resolved Hide resolved
test/Unit/Task/TwigCsFixerTest.php Show resolved Hide resolved
@veewee veewee added this to the 2.6.0 milestone May 17, 2024
@veewee
Copy link
Contributor

veewee commented May 17, 2024

Looks nice, thanks for your work !

@veewee veewee merged commit c9e3209 into phpro:v2.x May 17, 2024
20 checks passed
@antoniovj1
Copy link
Contributor Author

Looks nice, thanks for your work !

Thanks for your help and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants