Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add option to disable all banners by setting ascii to null #540

Merged
merged 2 commits into from
Sep 28, 2018
Merged

feat: Add option to disable all banners by setting ascii to null #540

merged 2 commits into from
Sep 28, 2018

Conversation

poppabear8883
Copy link
Contributor

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets None

To disable all banners set ascii to ~:

# grumphp.yml
parameters:
    ascii: ~

@poppabear8883 poppabear8883 mentioned this pull request Sep 18, 2018
Merged
@janvernieuwe
Copy link
Member

Tiny remark, but LGTM 👍

@veewee veewee added this to the Version 0.14.3 milestone Sep 28, 2018
@veewee veewee merged commit 56a29a6 into phpro:master Sep 28, 2018
@veewee
Copy link
Contributor

veewee commented Sep 28, 2018

Thanks for your work @poppabear8883 !

@poppabear8883 poppabear8883 deleted the feat-ascii-1 branch September 28, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvernieuwe janvernieuwe janvernieuwe left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 0.14.3
Development

Successfully merging this pull request may close these issues.
3 participants
@poppabear8883 @janvernieuwe @veewee