[ECS task] Run pre commit argument switch #652
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmatthiesen81
changed the title
veewee
requested changes
Jul 28, 2019
src/Task/Ecs.php
Outdated
| $arguments->addFiles($files); | ||
| } | ||
|
|
||
| if (!$config['files_on_pre_commit'] && $context instanceof RunContext) { |
There was a problem hiding this comment.
This statement doesn't seem right: in run context it should always use the whitelist instead of the files?
jmatthiesen81
force-pushed
the
run-pre-commit-argument-switch
branch
from
096cb00 to
daf0557
Compare
jmatthiesen81
force-pushed
the
run-pre-commit-argument-switch
branch
from
daf0557 to
cbcfab2
Compare
jmatthiesen81
force-pushed
the
run-pre-commit-argument-switch
branch
from
628274f to
4d75827
Compare
|
Thanks for the idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the task with the configuration
files_on_pre_committo check the staged files on the pre commit instead of the files in the directories configured inwhitelist_patterns. To keep the backward compatibility the configuration is disabled in the default.