-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[phpmd] Allow setting output format to ansi #766
Conversation
the linked doc doesn't mention the reporter but I made a PR for that on phpmd phpmd/phpmd#779 |
I'm sorry for the back and forth, I'm not able to run the tests locally because seemingly no tests work on my environment (osx, php7.4.2) getting lots of deprecation errors when running tests e.g
|
f0fe2d0
to
86de516
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! It looks good!
Added a small remark to improve the task, nothing big.
You could run the tests without the deprecation warnings by changing your ini settings. We have to take a look at upgrading the testsuites to newer versions.
Use OptionsResolver
a755916
to
82ea06f
Compare
Thanks for your work! |
Since 2.8 phpmd has a new, subjectively nicer, report format that is ansi
ansi
![Screen Shot 2020-05-08 at 1 07 25 PM](https://user-images.githubusercontent.com/39970/81440228-eaacc080-912c-11ea-975f-3172f87b1d74.png)
![image](https://user-images.githubusercontent.com/39970/81440337-1f207c80-912d-11ea-9c4a-9eef6d7ceee3.png)
text (current)
I did not set the default to ansi for this PR, as the renderer is not available in older versions of phpmd