Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phpmd] Allow setting output format to ansi #766

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

MarkVaughn
Copy link
Contributor

@MarkVaughn MarkVaughn commented May 8, 2020

Q A
Branch master for features and deprecations
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes

Since 2.8 phpmd has a new, subjectively nicer, report format that is ansi

ansi
Screen Shot 2020-05-08 at 1 07 25 PM
text (current)
image

I did not set the default to ansi for this PR, as the renderer is not available in older versions of phpmd

@MarkVaughn MarkVaughn changed the title Allow setting output format to ansi [phpmd] Allow setting output format to ansi May 8, 2020
@MarkVaughn
Copy link
Contributor Author

the linked doc doesn't mention the reporter but I made a PR for that on phpmd phpmd/phpmd#779

@MarkVaughn MarkVaughn requested a review from veewee July 7, 2020 20:29
test/Unit/Task/PhpMdTest.php Outdated Show resolved Hide resolved
@MarkVaughn
Copy link
Contributor Author

I'm sorry for the back and forth, I'm not able to run the tests locally because seemingly no tests work on my environment (osx, php7.4.2) getting lots of deprecation errors when running tests e.g

12) GrumPHPTest\Uni\Task\PhpMdTest::it_passes_on_stuff with data set "exitCode0" (array(), Double\GrumPHP\Task\Context\RunContext\P9 Object (...), Closure Object (...))
Function ReflectionType::__toString() is deprecated

Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks good!
Added a small remark to improve the task, nothing big.

You could run the tests without the deprecation warnings by changing your ini settings. We have to take a look at upgrading the testsuites to newer versions.

src/Task/PhpMd.php Outdated Show resolved Hide resolved
Use OptionsResolver
@veewee veewee added this to the 0.19.2 milestone Jul 15, 2020
@veewee veewee merged commit ad51a52 into phpro:master Jul 15, 2020
@veewee
Copy link
Contributor

veewee commented Jul 15, 2020

Thanks for your work!

@MarkVaughn MarkVaughn deleted the mark/allow-ansi branch July 24, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants