Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid config generation #773

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Fix invalid config generation #773

merged 1 commit into from
Jun 11, 2020

Conversation

veewee
Copy link
Contributor

@veewee veewee commented Jun 11, 2020

Q A
Branch 0.19.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets

When composer install does not find a grumphp.yml file, the configuration wizard is started.
Right after that, the grumphp git:init command is triggerd.
Since the content of the GrumPHP file still contains 'parameters', you get this error:

PHP Fatal error:  Uncaught GrumPHP\Exception\DeprecatedException: Direct configuration of parameter tasks is not allowed anymore.
Please rename the `parameters` section in your grumphp.yaml file to `grumphp`.
More info: https://github.com/phpro/grumphp/releases/tag/v0.19.0

@veewee veewee added the bug label Jun 11, 2020
@veewee veewee added this to the 0.19.1 milestone Jun 11, 2020
@veewee veewee merged commit 932ea23 into phpro:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.19.1
Development

Successfully merging this pull request may close these issues.
1 participant
@veewee