Make Travis green again on PHP 8! #782
Conversation
| @@ -22,7 +22,7 @@ matrix: | |||
| - php: nightly | |||
|
|
|||
| before_install: | |||
| - phpenv config-rm xdebug.ini | |||
| - phpenv config-rm xdebug.ini || true | |||
There was a problem hiding this comment.
Can you point me to a failure? I can't seem to find one related to this change?
There was a problem hiding this comment.
The thing is Xdebug is not available for PHP 8 yet so travis build was failing here. Suppressing it with || true allows script to continue if Xdebug was not installed. I added --ignore-platform-reqs flag to composer to let it install the dependencies on upcoming PHP version but the build is still failing because of the deprecation errors. At least we are able to see the errors so we can work on fixing them 😉 .
There was a problem hiding this comment.
Failures are related to phpspec/phpspec#1313
There was a problem hiding this comment.
ok, do you want to keep this PR open untill phpspec is fixed or do you want me to merge it in as-is?
There was a problem hiding this comment.
Merging now shouldn't hurt. We can just keep an eye on nightly CI sometimes to see if it's green because it's most likely only phpspec's problem and should be resolved soon without any changes to this repo.
|
Thanks for the PR! |
New Task Checklist: