Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] add Pest #812

Merged
merged 2 commits into from
Sep 1, 2020
Merged

[Task] add Pest #812

merged 2 commits into from
Sep 1, 2020

Conversation

oallain
Copy link
Contributor

@oallain oallain commented Aug 30, 2020 •
edited
Loading

Q A
Branch master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets #811

Add PestPHP https://pestphp.com to GrumPHP 🚀
Task done with ❤️ for Pest.

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

Execution with an output error (for show):

image

veewee
veewee reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@veewee veewee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast PR!
It looks good. Maybe the list of options is a bit short?

doc/tasks/pest.md
# grumphp.yml
grumphp:
tasks:
pest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to allow the same options as the phpunit task?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

The list of options provides by Pest is the same à PHPUnit, so yes, doing same here is a good idea 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPUnit provide testsuite and group, so i added it 🥰

@veewee veewee added this to the 0.22.0 milestone Aug 31, 2020
@oallain oallain closed this Aug 31, 2020
@oallain oallain reopened this Aug 31, 2020
@oallain
Copy link
Contributor Author

oallain commented Aug 31, 2020 •
edited
Loading

Just closed and reopen because of Travis bug 👎

@veewee veewee merged commit f5086a3 into phpro:master Sep 1, 2020
@veewee
Copy link
Contributor

veewee commented Sep 1, 2020

Thanks for your lovely PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veewee veewee veewee left review comments

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oallain @veewee