Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete sprintf from ExecutableNotFoundException callback #823

Merged
merged 1 commit into from Oct 2, 2020
Merged

Remove obsolete sprintf from ExecutableNotFoundException callback #823

merged 1 commit into from Oct 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 1, 2020

Q A
Branch master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets

When Grumphp throws an ExecutableNotFoundException via the ExternalCommand class it executes sprintf twice because the Exception contains the sprintf as well.. This was probably introduced during refactoring of the Exception. This pull request just removes the obsolete sprintf.

sprintf('The executable for "%s" could not be found.', $command)

Example of output before:

phpmd
=====

The executable for "The executable for "phpmd" could not be found." could not be found.

Example of output after:

phpmd
=====

The executable for "phpmd" could not be found.

@veewee veewee added this to the 1.1.0 milestone Oct 2, 2020
@veewee veewee merged commit eb5436f into phpro:master Oct 2, 2020
@veewee
Copy link
Contributor

veewee commented Oct 2, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant