Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unknown options from phpcpd task documentation #826

Merged
merged 1 commit into from Oct 2, 2020
Merged

Remove unknown options from phpcpd task documentation #826

merged 1 commit into from Oct 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2020

Q A
Branch master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Documented? yes
Fixed tickets

When executing phpcpd through grumphp with the default settings copied from the documentation page to my grumphp.yml file it throws the following error:

In OptionsResolver.php line 871:
                                                                               
  The options "names_exclude", "regexps_exclude" do not exist. Defined option  
  s are: "directory", "exclude", "fuzzy", "min_lines", "min_tokens", "trigger  
  ed_by".  

This pull requests removes the unknown options from the documentation page.

@veewee veewee added this to the 1.1.0 milestone Oct 2, 2020
@veewee veewee merged commit aadc27b into phpro:master Oct 2, 2020
@veewee
Copy link
Contributor

veewee commented Oct 2, 2020

Thanks! Really appreciate those small improvements! It's easy to overlook those ...

@ghost
Copy link
Author

ghost commented Oct 2, 2020

No problem @veewee , I'm currently trying to setup a stack library that requires all the suggested packages for global grumphp usage. This is why I'm testing each and every command separately. So I can automate the releases for this package.

https://github.com/verbruggenalex/grumphp-stack/blob/master/composer.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant