Made Ecs task fixable #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzysztof-ciszewski
force-pushed
the
master
branch
from
e5be06e to
ac1c10b
Compare
|
Hello A year ago @veewee told me, grumphp don't fix anything, see #625 (comment) |
|
@oallain we added a fixer component to grumphp, that works in a consistent and safe way. so that faq item is no longer relevant. Will try to take a deeper look at this PR soon. |
|
@veewee, thnaks for answer, good news ! |
oallain
approved these changes
Oct 6, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ecs task now returns a
FixableTaskResultallowing it to work with thefixerparameter.