Implement refactored formatter options for Deptrac >= v0.9.0 #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veewee
reviewed
Nov 26, 2020
There was a problem hiding this comment.
Hello,
Thanks for the PR!
This configuration is becoming quite hard for the end user.
Since the tool is in 0.X versioing state, people know it is quite experimental.
I'dd suggest only adding the new types without providing BC grumphp configuration.
What do you think?
It certainly makes it easier indeed. As it's below v1.0, I agree with you. I will remove the pre-v0.9 options completely 👍 |
Deptrac has changed the options for formatters since version 0.9.0. These new graphviz formatting options replace the old options, as Deptrac is still in experimental phase (version below 1.0).
jerowork
force-pushed
the
fix/deptrac-enable-0.9.0-formatter-configuration
branch
from
f82d6c4 to
8646bce
Compare
veewee
approved these changes
Dec 14, 2020
|
Thanks for changing and adding the options! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deptrac has updated formatter options in
v0.9.0. They enabled new formatters (e.g. baseline, table) and refactored existing formatters (e.g. Graphviz). This means that the previous options are not working anymore. New options are introduced for existing formatters.This PR adds all new formatters with its new options to the
DeptracTask.See commit descriptions for further information.
Resources