Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch ExecutableNotFoundException #855

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Catch ExecutableNotFoundException #855

merged 1 commit into from
Dec 16, 2020

Conversation

prudloff-insite
Copy link
Contributor

Q A
Branch master for features and deprecations
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Documented? no
Fixed tickets

Right now, only CommandNotFoundException is caught but ProcessBuilder::createArgumentsForCommand() can throw ExecutableNotFoundException.

This means that if phpcbf is not available, it will fail with only:

The executable for "phpcfbf" could not be found.

Instead of showing the errors + suggesting to install phpcbf.

@veewee veewee added this to the 1.3.0 milestone Dec 16, 2020
@veewee
Copy link
Contributor

veewee commented Dec 16, 2020

That's much better indeed! Thanks for the PR!

@veewee veewee merged commit 76b38f4 into phpro:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@prudloff-insite @veewee