Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig #999

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Add .editorconfig #999

merged 1 commit into from
Apr 8, 2022

Conversation

danepowell
Copy link
Contributor

Q A
Branch master for features and deprecations
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Deprecations? yes/no
Documented? yes/no
Fixed tickets comma-separated list of tickets fixed by the PR, if any

I normally use 2 spaces with PHP, so every time I touch this project I'm fighting default PhpStorm settings 😄

Using editorconfig would make contributors' lives easier by enforcing this automatically.

New Task Checklist:

  • Are the dependencies added to the composer.json suggestions?
  • Is the doc/tasks.md file updated?
  • Are the task parameters documented?
  • Is the task registered in the tasks.yml file?
  • Does the task contains phpunit tests?
  • Is the configuration having logical allowed types?
  • Does the task run in the correct context?
  • Is the run() method readable?
  • Is the run() method using the configuration correctly?
  • Are all CI services returning green?

@veewee veewee added this to the 1.11.0 milestone Apr 8, 2022
@veewee
Copy link
Contributor

veewee commented Apr 8, 2022

Looks good, thanks!

@veewee veewee merged commit de4402f into phpro:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants