Merge pull request #525 from ciaranmcnulty/false-types

Support the false pseudotype, which cannot be nullable or standalone
phpspec · Mar 17, 2021 · 26ec19b · 26ec19b
2 parents 3f22964 + 2b882e1
commit 26ec19b
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 1 deletion.
diff --git a/spec/Prophecy/Doubler/Generator/Node/ArgumentTypeNodeSpec.php b/spec/Prophecy/Doubler/Generator/Node/ArgumentTypeNodeSpec.php
@@ -84,4 +84,29 @@ function it_does_not_allow_union_mixed()
             $this->shouldThrow(DoubleException::class)->duringInstantiation();
         }
     }
+
+    function it_does_not_prefix_false()
+    {
+        $this->beConstructedWith('false', 'array');
+
+        $this->getTypes()->shouldReturn(['false', 'array']);
+    }
+
+    function it_does_not_allow_standalone_false()
+    {
+        $this->beConstructedWith('false');
+
+        if (PHP_VERSION_ID >=80000) {
+            $this->shouldThrow(DoubleException::class)->duringInstantiation();
+        }
+    }
+
+    function it_does_not_allow_nullable_false()
+    {
+        $this->beConstructedWith('null', 'false');
+
+        if (PHP_VERSION_ID >=80000) {
+            $this->shouldThrow(DoubleException::class)->duringInstantiation();
+        }
+    }
 }
diff --git a/spec/Prophecy/Doubler/Generator/Node/ReturnTypeNodeSpec.php b/spec/Prophecy/Doubler/Generator/Node/ReturnTypeNodeSpec.php
@@ -118,4 +118,29 @@ function it_knows_when_it_is_void()
 
         $this->shouldBeVoid();
     }
+
+    function it_does_not_prefix_false()
+    {
+        $this->beConstructedWith('false', 'array');
+
+        $this->getTypes()->shouldReturn(['false', 'array']);
+    }
+
+    function it_does_not_allow_standalone_false()
+    {
+        $this->beConstructedWith('false');
+
+        if (PHP_VERSION_ID >=80000) {
+            $this->shouldThrow(DoubleException::class)->duringInstantiation();
+        }
+    }
+
+    function it_does_not_allow_nullable_false()
+    {
+        $this->beConstructedWith('null', 'false');
+
+        if (PHP_VERSION_ID >=80000) {
+            $this->shouldThrow(DoubleException::class)->duringInstantiation();
+        }
+    }
 }
diff --git a/src/Prophecy/Doubler/Generator/Node/TypeNodeAbstract.php b/src/Prophecy/Doubler/Generator/Node/TypeNodeAbstract.php
@@ -59,6 +59,7 @@ protected function getRealType(string $type): string
             case 'array':
             case 'callable':
             case 'bool':
+            case 'false':
             case 'float':
             case 'int':
             case 'string':
@@ -77,7 +78,15 @@ protected function getRealType(string $type): string
     protected function guardIsValidType()
     {
         if ($this->types == ['null' => 'null']) {
-            throw new DoubleException('Argument type cannot be standalone null');
+            throw new DoubleException('Type cannot be standalone null');
+        }
+
+        if ($this->types == ['false' => 'false']) {
+            throw new DoubleException('Type cannot be standalone false');
+        }
+
+        if ($this->types == ['false' => 'false', 'null' => 'null']) {
+            throw new DoubleException('Type cannot be nullable false');
         }
 
         if (\PHP_VERSION_ID >= 80000 && isset($this->types['mixed']) && count($this->types) !== 1) {