Skip to content

Commit

Permalink
Rename DescriptorRegistry to DefaultDescriptorRegistry
Browse files Browse the repository at this point in the history
  • Loading branch information
ruudk authored and ondrejmirtes committed Jan 5, 2024
1 parent ba2a588 commit de3d49a
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion extension.neon
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ services:
-
class: PHPStan\Type\Doctrine\DescriptorRegistryFactory
-
class: PHPStan\Type\Doctrine\DescriptorRegistry
class: PHPStan\Type\Doctrine\DefaultDescriptorRegistry
factory: @PHPStan\Type\Doctrine\DescriptorRegistryFactory::createRegistry

-
Expand Down
6 changes: 3 additions & 3 deletions src/Rules/Doctrine/ORM/EntityColumnRule.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Type\ArrayType;
use PHPStan\Type\Doctrine\DescriptorNotRegisteredException;
use PHPStan\Type\Doctrine\DescriptorRegistry;
use PHPStan\Type\Doctrine\DefaultDescriptorRegistry;
use PHPStan\Type\Doctrine\ObjectMetadataResolver;
use PHPStan\Type\ErrorType;
use PHPStan\Type\MixedType;
Expand All @@ -36,7 +36,7 @@ class EntityColumnRule implements Rule
/** @var ObjectMetadataResolver */
private $objectMetadataResolver;

/** @var DescriptorRegistry */
/** @var DefaultDescriptorRegistry */
private $descriptorRegistry;

/** @var ReflectionProvider */
Expand All @@ -53,7 +53,7 @@ class EntityColumnRule implements Rule

public function __construct(
ObjectMetadataResolver $objectMetadataResolver,
DescriptorRegistry $descriptorRegistry,
DefaultDescriptorRegistry $descriptorRegistry,
ReflectionProvider $reflectionProvider,
bool $reportUnknownTypes,
bool $allowNullablePropertyForRequiredField,
Expand Down
4 changes: 2 additions & 2 deletions src/Type/Doctrine/CreateQueryDynamicReturnTypeExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ final class CreateQueryDynamicReturnTypeExtension implements DynamicMethodReturn
/** @var ObjectMetadataResolver */
private $objectMetadataResolver;

/** @var DescriptorRegistry */
/** @var DefaultDescriptorRegistry */
private $descriptorRegistry;

public function __construct(ObjectMetadataResolver $objectMetadataResolver, DescriptorRegistry $descriptorRegistry)
public function __construct(ObjectMetadataResolver $objectMetadataResolver, DefaultDescriptorRegistry $descriptorRegistry)
{
$this->objectMetadataResolver = $objectMetadataResolver;
$this->descriptorRegistry = $descriptorRegistry;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Doctrine\DBAL\Types\Type;
use PHPStan\Type\Doctrine\Descriptors\DoctrineTypeDescriptor;

class DescriptorRegistry
class DefaultDescriptorRegistry
{

/** @var array<class-string<Type>, DoctrineTypeDescriptor> */
Expand Down
4 changes: 2 additions & 2 deletions src/Type/Doctrine/DescriptorRegistryFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ public function __construct(Container $container)
$this->container = $container;
}

public function createRegistry(): DescriptorRegistry
public function createRegistry(): DefaultDescriptorRegistry
{
return new DescriptorRegistry($this->container->getServicesByTag(self::TYPE_DESCRIPTOR_TAG));
return new DefaultDescriptorRegistry($this->container->getServicesByTag(self::TYPE_DESCRIPTOR_TAG));
}

}
10 changes: 5 additions & 5 deletions src/Type/Doctrine/Query/QueryResultTypeWalker.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use PHPStan\Type\Constant\ConstantStringType;
use PHPStan\Type\ConstantTypeHelper;
use PHPStan\Type\Doctrine\DescriptorNotRegisteredException;
use PHPStan\Type\Doctrine\DescriptorRegistry;
use PHPStan\Type\Doctrine\DefaultDescriptorRegistry;
use PHPStan\Type\FloatType;
use PHPStan\Type\GeneralizePrecision;
use PHPStan\Type\IntegerRangeType;
Expand Down Expand Up @@ -97,7 +97,7 @@ class QueryResultTypeWalker extends SqlWalker
/** @var QueryResultTypeBuilder */
private $typeBuilder;

/** @var DescriptorRegistry */
/** @var DefaultDescriptorRegistry */
private $descriptorRegistry;

/** @var bool */
Expand All @@ -109,7 +109,7 @@ class QueryResultTypeWalker extends SqlWalker
/**
* @param Query<mixed> $query
*/
public static function walk(Query $query, QueryResultTypeBuilder $typeBuilder, DescriptorRegistry $descriptorRegistry): void
public static function walk(Query $query, QueryResultTypeBuilder $typeBuilder, DefaultDescriptorRegistry $descriptorRegistry): void
{
$query->setHint(Query::HINT_CUSTOM_OUTPUT_WALKER, self::class);
$query->setHint(self::HINT_TYPE_MAPPING, $typeBuilder);
Expand Down Expand Up @@ -154,11 +154,11 @@ public function __construct($query, $parserResult, array $queryComponents)

$descriptorRegistry = $this->query->getHint(self::HINT_DESCRIPTOR_REGISTRY);

if (!$descriptorRegistry instanceof DescriptorRegistry) {
if (!$descriptorRegistry instanceof DefaultDescriptorRegistry) {
throw new ShouldNotHappenException(sprintf(
'Expected the query hint %s to contain a %s, but got a %s',
self::HINT_DESCRIPTOR_REGISTRY,
DescriptorRegistry::class,
DefaultDescriptorRegistry::class,
is_object($descriptorRegistry) ? get_class($descriptorRegistry) : gettype($descriptorRegistry)
));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
use PHPStan\Reflection\ParametersAcceptorSelector;
use PHPStan\Rules\Doctrine\ORM\DynamicQueryBuilderArgumentException;
use PHPStan\Type\Doctrine\ArgumentsProcessor;
use PHPStan\Type\Doctrine\DescriptorRegistry;
use PHPStan\Type\Doctrine\DefaultDescriptorRegistry;
use PHPStan\Type\Doctrine\DoctrineTypeUtils;
use PHPStan\Type\Doctrine\ObjectMetadataResolver;
use PHPStan\Type\Doctrine\Query\QueryResultTypeBuilder;
Expand Down Expand Up @@ -62,7 +62,7 @@ class QueryBuilderGetQueryDynamicReturnTypeExtension implements DynamicMethodRet
/** @var string|null */
private $queryBuilderClass;

/** @var DescriptorRegistry */
/** @var DefaultDescriptorRegistry */
private $descriptorRegistry;

/** @var OtherMethodQueryBuilderParser */
Expand All @@ -72,7 +72,7 @@ public function __construct(
ObjectMetadataResolver $objectMetadataResolver,
ArgumentsProcessor $argumentsProcessor,
?string $queryBuilderClass,
DescriptorRegistry $descriptorRegistry,
DefaultDescriptorRegistry $descriptorRegistry,
OtherMethodQueryBuilderParser $otherMethodQueryBuilderParser
)
{
Expand Down
4 changes: 2 additions & 2 deletions tests/Rules/Doctrine/ORM/EntityColumnRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Iterator;
use PHPStan\Rules\Rule;
use PHPStan\Testing\RuleTestCase;
use PHPStan\Type\Doctrine\DescriptorRegistry;
use PHPStan\Type\Doctrine\DefaultDescriptorRegistry;
use PHPStan\Type\Doctrine\Descriptors\ArrayType;
use PHPStan\Type\Doctrine\Descriptors\BigIntType;
use PHPStan\Type\Doctrine\Descriptors\BinaryType;
Expand Down Expand Up @@ -58,7 +58,7 @@ protected function getRule(): Rule

return new EntityColumnRule(
new ObjectMetadataResolver($this->objectManagerLoader, __DIR__ . '/../../../../tmp'),
new DescriptorRegistry([
new DefaultDescriptorRegistry([
new ArrayType(),
new BigIntType(),
new BinaryType(),
Expand Down
6 changes: 3 additions & 3 deletions tests/Type/Doctrine/Query/QueryResultTypeWalkerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use PHPStan\Type\Constant\ConstantIntegerType;
use PHPStan\Type\Constant\ConstantStringType;
use PHPStan\Type\ConstantTypeHelper;
use PHPStan\Type\Doctrine\DescriptorRegistry;
use PHPStan\Type\Doctrine\DefaultDescriptorRegistry;
use PHPStan\Type\FloatType;
use PHPStan\Type\IntegerRangeType;
use PHPStan\Type\IntegerType;
Expand Down Expand Up @@ -58,7 +58,7 @@ final class QueryResultTypeWalkerTest extends PHPStanTestCase
/** @var EntityManagerInterface */
private static $em;

/** @var DescriptorRegistry */
/** @var DefaultDescriptorRegistry */
private $descriptorRegistry;

public static function getAdditionalConfigFiles(): array
Expand Down Expand Up @@ -184,7 +184,7 @@ public static function tearDownAfterClass(): void

public function setUp(): void
{
$this->descriptorRegistry = self::getContainer()->getByType(DescriptorRegistry::class);
$this->descriptorRegistry = self::getContainer()->getByType(DefaultDescriptorRegistry::class);
}

/** @dataProvider getTestData */
Expand Down

0 comments on commit de3d49a

Please sign in to comment.