SprintfFunctionDynamicReturnTypeExtension - limit combinatorial explo…

…sion
phpstan · Feb 5, 2024 · 51cffd4 · 51cffd4
1 parent aeadbe2
commit 51cffd4
Show file tree

Hide file tree

Showing 3 changed files with 58 additions and 1 deletion.
diff --git a/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php b/src/Type/Php/SprintfFunctionDynamicReturnTypeExtension.php
@@ -85,13 +85,20 @@ public function getTypeFromFunctionCall(
 		}
 
 		$values = [];
+		$combinationsCount = 1;
 		foreach ($args as $arg) {
 			$argType = $scope->getType($arg->value);
 			if (count($argType->getConstantScalarValues()) === 0) {
 				return $returnType;
 			}
 
-			$values[] = $argType->getConstantScalarValues();
+			$constantScalarValues = $argType->getConstantScalarValues();
+			$values[] = $constantScalarValues;
+			$combinationsCount *= count($constantScalarValues);
+		}
+
+		if ($combinationsCount > InitializerExprTypeResolver::CALCULATE_SCALARS_LIMIT) {
+			return $returnType;
 		}
 
 		$combinations = CombinationsHelper::combinations($values);

diff --git a/tests/PHPStan/Analyser/AnalyserIntegrationTest.php b/tests/PHPStan/Analyser/AnalyserIntegrationTest.php
@@ -1294,6 +1294,12 @@ public function testBug10509(): void
 		$this->assertSame('PHPDoc tag @return contains unresolvable type.', $errors[1]->getMessage());
 	}
 
+	public function testBug10538(): void
+	{
+		$errors = $this->runAnalyse(__DIR__ . '/data/bug-10538.php');
+		$this->assertNoErrors($errors);
+	}
+
 	/**
 	 * @param string[]|null $allAnalysedFiles
 	 * @return Error[]