IssetCheck - respect treatPhpDocTypesAsCertain for variables

src/Rules/IssetCheck.php

@@ -45,7 +45,7 @@ public function check(Expr $expr, Scope $scope, string $operatorDescription, cal
 					}
 
 					return $this->generateError(
-						$scope->getVariableType($expr->name),
+						$this->treatPhpDocTypesAsCertain ? $scope->getType($expr) : $scope->getNativeType($expr),
 						sprintf('Variable $%s %s always exists and', $expr->name, $operatorDescription),
 						$typeMessageCallback,
 					);

tests/PHPStan/Rules/Variables/EmptyRuleTest.php

@@ -91,6 +91,26 @@ public function testBug6974(): void
 	{
 		$this->treatPhpDocTypesAsCertain = false;
 		$this->strictUnnecessaryNullsafePropertyFetch = false;
+		$this->analyse([__DIR__ . '/data/bug-6974.php'], [
+			[
+				'Variable $a in empty() always exists and is always falsy.',
+				12,
+			],
+			[
+				'Variable $a in empty() always exists and is always falsy.',
+				21,
+			],
+			[
+				'Variable $a in empty() always exists and is always falsy.',
+				30,
+			],
+		]);
+	}
+
+	public function testBug6974TreatPhpDocTypesAsCertain(): void
+	{
+		$this->treatPhpDocTypesAsCertain = true;
+		$this->strictUnnecessaryNullsafePropertyFetch = false;
 		$this->analyse([__DIR__ . '/data/bug-6974.php'], [
 			[
 				'Variable $a in empty() always exists and is always falsy.',
@@ -193,4 +213,12 @@ public function testBug7199(): void
 		$this->analyse([__DIR__ . '/data/bug-7199.php'], []);
 	}
 
+	public function testBug9126(): void
+	{
+		$this->treatPhpDocTypesAsCertain = false;
+		$this->strictUnnecessaryNullsafePropertyFetch = false;
+
+		$this->analyse([__DIR__ . '/data/bug-9126.php'], []);
+	}
+
 }

tests/PHPStan/Rules/Variables/data/bug-9126.php

@@ -0,0 +1,23 @@
+<?php
+
+namespace Bug9126;
+
+class User {}
+
+class Resume {
+
+	/**
+	 * @return User
+	 */
+	public function getOwner() {
+		return $this->owner;
+	}
+}
+
+function (): void {
+	$resume = new Resume();
+	$owner = $resume->getOwner();
+	if (!empty($owner)) {
+		echo "not empty";
+	}
+};