Nullsafe operator on null results in null

phpstan · Aug 7, 2023 · 5c40c85 · 5c40c85
1 parent 4d77e98
commit 5c40c85
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Analyser/MutatingScope.php b/src/Analyser/MutatingScope.php
@@ -1702,6 +1702,9 @@ private function resolveType(string $exprString, Expr $node): Type
 
 		if ($node instanceof Expr\NullsafeMethodCall) {
 			$varType = $this->getType($node->var);
+			if ($varType->isNull()->yes()) {
+				return new NullType();
+			}
 			if (!TypeCombinator::containsNull($varType)) {
 				return $this->getType(new MethodCall($node->var, $node->name, $node->args));
 			}
@@ -1797,6 +1800,9 @@ private function resolveType(string $exprString, Expr $node): Type
 
 		if ($node instanceof Expr\NullsafePropertyFetch) {
 			$varType = $this->getType($node->var);
+			if ($varType->isNull()->yes()) {
+				return new NullType();
+			}
 			if (!TypeCombinator::containsNull($varType)) {
 				return $this->getType(new PropertyFetch($node->var, $node->name));
 			}

diff --git a/tests/PHPStan/Analyser/data/nullsafe.php b/tests/PHPStan/Analyser/data/nullsafe.php
@@ -99,4 +99,11 @@ public function doDolor(?self $self)
 		assertType('Nullsafe\Foo|null', $self?->nullableSelf);
 	}
 
+	public function doNull(): void
+	{
+		$null = null;
+		assertType('null', $null?->foo);
+		assertType('null', $null?->doFoo());
+	}
+
 }