Fix gettype in match

phpstan · Jun 19, 2023 · caa0a5b · caa0a5b
1 parent aa66b84
commit caa0a5b
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 0 deletions.
diff --git a/src/Analyser/TypeSpecifier.php b/src/Analyser/TypeSpecifier.php
@@ -226,6 +226,9 @@ public function specifyTypesInCondition(
 				}
 
 				if ($types !== null) {
+					if ($leftExpr !== $unwrappedLeftExpr) {
+						$types = $types->unionWith($this->create($leftExpr, $rightType, $context, false, $scope, $rootExpr));
+					}
 					return $types;
 				}
 			}

diff --git a/tests/PHPStan/Rules/Comparison/MatchExpressionRuleTest.php b/tests/PHPStan/Rules/Comparison/MatchExpressionRuleTest.php
@@ -498,4 +498,13 @@ public function testBug9457(): void
 		$this->analyse([__DIR__ . '/data/bug-9457.php'], []);
 	}
 
+	public function testBug8614(): void
+	{
+		if (PHP_VERSION_ID < 80100) {
+			$this->markTestSkipped('Test requires PHP 8.1.');
+		}
+
+		$this->analyse([__DIR__ . '/data/bug-8614.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Comparison/data/bug-8614.php b/tests/PHPStan/Rules/Comparison/data/bug-8614.php
@@ -0,0 +1,14 @@
+<?php // lint >= 8.1
+
+namespace Bug8614;
+
+/**
+ * @param int|float|bool|string|object|mixed[] $value
+ */
+function stringify(int|float|bool|string|object|array $value): string
+{
+	return match (gettype($value)) {
+		'integer', 'double', 'boolean', 'string' => (string) $value,
+		'object', 'array' => var_export($value, true),
+	};
+}